Fix basis.

Author: kinyoklion

packages/sdk/browser/src/BrowserFDv2DataManager.ts

@@ -130,7 +130,7 @@ export default class BrowserFDv2DataManager implements DataManager {
 
     // Streaming synchronizer — primary, for live updates.
     const streamingEndpoints = endpoints.streaming();
-    const streamingSyncFactory = (_sg: () => string | undefined) => {
+    const streamingSyncFactory = (sg: () => string | undefined) => {
       const streamUriPath = streamingEndpoints.pathGet(
         this._platform.encoding!,
         plainContextString,
@@ -140,6 +140,7 @@ export default class BrowserFDv2DataManager implements DataManager {
         serviceEndpoints: this._config.serviceEndpoints,
         streamUriPath,
         parameters: queryParams,
+        selectorGetter: sg,
         headers: this._baseHeaders,
         initialRetryDelayMillis: this._config.streamInitialReconnectDelay * 1000,
         logger: this._logger,

packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts

@@ -430,6 +430,58 @@ it('produces results in order', async () => {
   base.close();
 });
 
+it('includes basis parameter in stream URI when selectorGetter returns a value', () => {
+  const mockEventSource = createMockEventSource();
+  const mockRequests = createMockRequests(mockEventSource);
+
+  const base = createBase(mockRequests, logger, {
+    streamUriPath: '/sdk/stream/eval/ctx',
+    parameters: [{ key: 'auth', value: 'my-key' }],
+    selectorGetter: () => '(p:test:1)',
+  });
+  base.start();
+
+  const uri = mockRequests.createEventSource.mock.calls[0][0];
+  expect(uri).toContain(`basis=${encodeURIComponent('(p:test:1)')}`);
+  expect(uri).toContain('auth=my-key');
+
+  base.close();
+});
+
+it('does not include basis parameter when selectorGetter returns undefined', () => {
+  const mockEventSource = createMockEventSource();
+  const mockRequests = createMockRequests(mockEventSource);
+
+  const base = createBase(mockRequests, logger, {
+    streamUriPath: '/sdk/stream/eval/ctx',
+    parameters: [{ key: 'auth', value: 'my-key' }],
+    selectorGetter: () => undefined,
+  });
+  base.start();
+
+  const uri = mockRequests.createEventSource.mock.calls[0][0];
+  expect(uri).not.toContain('basis');
+  expect(uri).toContain('auth=my-key');
+
+  base.close();
+});
+
+it('does not include basis parameter when no selectorGetter is provided', () => {
+  const mockEventSource = createMockEventSource();
+  const mockRequests = createMockRequests(mockEventSource);
+
+  const base = createBase(mockRequests, logger, {
+    streamUriPath: '/sdk/stream/eval/ctx',
+    parameters: [{ key: 'auth', value: 'my-key' }],
+  });
+  base.start();
+
+  const uri = mockRequests.createEventSource.mock.calls[0][0];
+  expect(uri).not.toContain('basis');
+
+  base.close();
+});
+
 it('close is idempotent', () => {
   const mockEventSource = createMockEventSource();
   const mockRequests = createMockRequests(mockEventSource);

packages/shared/sdk-client/__tests__/datasource/fdv2/streamingTestHelpers.ts

@@ -114,13 +114,15 @@ export function createBase(
     pingHandler?: PingHandler;
     streamUriPath?: string;
     parameters?: { key: string; value: string }[];
+    selectorGetter?: () => string | undefined;
   } = {},
 ) {
   return createStreamingBase({
     requests: mockRequests as any,
     serviceEndpoints,
     streamUriPath: options.streamUriPath ?? '/sdk/stream/eval/test-context',
     parameters: options.parameters ?? [],
+    selectorGetter: options.selectorGetter,
     headers: baseHeaders,
     initialRetryDelayMillis: 1000,
     logger,

packages/shared/sdk-client/src/datasource/fdv2/StreamingFDv2Base.ts

@@ -83,6 +83,7 @@ export function createStreamingBase(config: {
   serviceEndpoints: ServiceEndpoints;
   streamUriPath: string;
   parameters: { key: string; value: string }[];
+  selectorGetter?: () => string | undefined;
   headers: LDHeaders;
   initialRetryDelayMillis: number;
   logger?: LDLogger;
@@ -95,13 +96,17 @@ export function createStreamingBase(config: {
     config.logger,
   );
 
-  const streamUri = getStreamingUri(
-    config.serviceEndpoints,
-    config.streamUriPath,
-    config.parameters,
-  );
   const headers: { [key: string]: string | string[] } = { ...config.headers };
 
+  function buildStreamUri(): string {
+    const params = [...config.parameters];
+    const basis = config.selectorGetter?.();
+    if (basis) {
+      params.push({ key: 'basis', value: encodeURIComponent(basis) });
+    }
+    return getStreamingUri(config.serviceEndpoints, config.streamUriPath, params);
+  }
+
   let eventSource: EventSource | undefined;
   let connectionAttemptStartTime: number | undefined;
   let fdv1Fallback = false;
@@ -260,7 +265,7 @@ export function createStreamingBase(config: {
 
       logConnectionAttempt();
 
-      const es = config.requests.createEventSource(streamUri, {
+      const es = config.requests.createEventSource(buildStreamUri(), {
         headers,
         errorFilter: (error: HttpErrorResponse) => handleError(error),
         initialRetryDelayMillis: config.initialRetryDelayMillis,