Fix possible null reference

launchdarkly · Jan 15, 2025 · 07f8ce0 · 07f8ce0
1 parent 1e777c6
commit 07f8ce0
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/LaunchDarkly/Impl/BigSegments/StoreManager.php b/src/LaunchDarkly/Impl/BigSegments/StoreManager.php
@@ -43,17 +43,19 @@ public function getContextMembership(string $contextKey): ?Impl\BigSegments\Memb
             return null;
         }
 
-        $cachedItem = $this->config->cache?->getItem($contextKey);
+        $cachedItem = null;
+        try {
+            $cachedItem = $this->config->cache?->getItem($contextKey);
+        } catch (Exception $e) {
+            $this->logger->warning("Failed to retrieve cached item for big segment", ['contextKey' => $contextKey, 'exception' => $e->getMessage()]);
+        }
         /** @var ?array */
         $membership = $cachedItem?->get();
 
         if ($membership === null) {
             try {
                 $membership = $this->store->getMembership(StoreManager::hashForContextKey($contextKey));
-                if ($this->config->cache !== null) {
-                    /**
-                     * @psalm-suppress PossiblyNullArgument
-                     */
+                if ($this->config->cache !== null && $cachedItem !== null) {
                     $cachedItem->set($membership)->expiresAfter($this->config->contextCacheTime);
 
                     if (!$this->config->cache->save($cachedItem)) {