Suggestion to rename `config.GetValue` to `config.GetKeyValue`

[davidferlay]

Obeserved

• There are currently 2 processors in launchrctl:

  • config.GetValue
  • keyring.GetKeyValue

• Naming is not very consistent whereas both processors have a similar role

Expected

• For consistency, I suggest to rename config.GetValue to config.GetKeyValue
• Optionaly, support for old naming can be kept but deprecate with display of a warning when it's used

[lexbritvin]

I am not against the change, but since the issue about naming, I don't see a real reason to do that.
In keyring we have Key pairs in KeyValue secret storage. We as well have Url credentials. It possibly may be keyring.GetUrlCredentials
In Config we are retrieving config values which are obviously searched by key.

I would rather have config.Value and keyring.KeyValue because having Get is a bit cumbersome for me.

[davidferlay]

Thanks for the explanation 👌 So it looks like legit naming after all, let's leave it as is 🤝