PR feedback

mrjo118 · mrjo118 · commit a69b2dfba586 · 2026-04-20T22:39:54.000+01:00
diff --git a/packages/lib/models/settings/FileHandler.ts b/packages/lib/models/settings/FileHandler.ts
@@ -80,10 +80,7 @@ export default class FileHandler {
 
 		if (overwrite) {
 			// Prevent pre-existing settings from being re-instated by subsequent saving of settings
-			this.parsedJsonCache_ = {
-				'$schema': Setting.schemaUrl,
-				...values,
-			};
+			this.parsedJsonCache_ = values;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -80,10 +80,7 @@ export default class FileHandler {`
`80`	`80`
`81`	`81`	`if (overwrite) {`
`82`	`82`	`// Prevent pre-existing settings from being re-instated by subsequent saving of settings`
`83`		`- this.parsedJsonCache_ = {`
`84`		`- '$schema': Setting.schemaUrl,`
`85`		`- ...values,`
`86`		`- };`
	`83`	`+ this.parsedJsonCache_ = values;`
`87`	`84`	`}`
`88`	`85`	`}`
`89`	`86`