Error message is incorrect when plugin manifest is invalid

[laurent22]

Example: chrubble/google-keep-to-joplin#2

The manifest is missing the app_min_version but instead the error says that it doesn't support Joplin Desktop (even though it's supposed to).

That was the manifest:

	"google-keep-to-joplin": {
		"manifest_version": 1,
		"id": "google-keep-to-joplin",
		"name": "Google Keep to Joplin Importer",
		"description": "Import your notes from Google Keep Takeout (JSON format) directly into Joplin. Transfers note titles, content, labels as tags, and attachments where supported. Designed for seamless migration from Google Keep to Joplin.",
		"version": "1.0.0",
		"platforms": [
			"desktop",
			"web",
			"mobile"
		],
		"author": "chrubble",
		"homepage_url": "https://github.com/chrubble/google-keep-to-joplin",
		"repository_url": "https://github.com/chrubble/google-keep-to-joplin",
		"keywords": [
			"joplin-plugin",
			"import",
			"google keep",
			"takeout",
			"notes",
			"migration"
		],
		"min_app_version": "2.8",
		"icon": "icon.png",
		"_publish_hash": "sha256:c22457a635c9cce563f3cc60fb2a8d6fa5fff3b5a66417ebdbcf66661ab550a1",
		"_publish_commit": "main:31ab80140024f6c81b817c6bc477fbe7e15f98c5",
		"_npm_package_name": "joplin-plugin-google-keep-to-joplin-importer",
		"_obsolete_reason": "Invalid manifest, no published source code, and unmaintained"
	}

[dbonfigli]

this is due to the bad min_app_version field that should be app_min_version as mentioned in chrubble/google-keep-to-joplin#1. I see the plugin is no longer listed on the joplin website and on the original repo it has been taken down. Personally I needed it and was able to make it work and fix a couple of other issues like not properly handling labels and importing original dates, you can see the fixes here.

[laurent22]

Yes, but this particular issue is about displaying a proper error message when a property is missing (in this particular case the user indeed put the wrong property name).

As for the plugin, it's broken and unmaintained which is why it was removed. If you have a working version maybe you can publish it yourself? I believe the original plugin was open source

[dbonfigli]

ah yes you are right indeed.

Regarding the new plugin, good suggestion, I cannot publish it as is because it is reverse engineered from the compiled one from chrubble so it is basically not presentable up to standards, but it is so simple that i can just rewrite it from the current working version and make it presentable. I am new to Joplin but from the doc i see that it should be straightforward 👍 .