arst

Author: laverdet

.github/actions/v8/action.yml

@@ -86,10 +86,9 @@ runs:
         echo ::group::Build v8
         case "$PLATFORM" in
           darwin)
-            export CLANG_BASE_PATH=$(brew --cellar llvm)/$(brew list --versions llvm | cut -d' ' -f2 | sort -V | head -n1)
+            export CLANG_BASE_PATH="$(brew --cellar llvm)/$(brew list --versions llvm | cut -d' ' -f2 | sort -V | head -n1)"
             ;;
           win32)
-            export CLANG_BASE_PATH=$(dirname $(which clang))/..
             export DEPOT_TOOLS_WIN_TOOLCHAIN=0
             ;;
         esac

.github/workflows/build-test-release.yml

@@ -116,7 +116,7 @@ jobs:
         if: matrix.host.platform == 'linux-gnu'
         run: apt-get -qq install --no-install-recommends -y curl; curl -kfsSL https://deb.nodesource.com/setup_24.x | bash -
       - name: Toolchain [Linux]
-        uses: laverdet/install@d85f8456c727ae6a488d5a006f4da67accabf21d
+        uses: laverdet/install@1502f1b253341d42ee2096469c84d52b5f896a38
         if: startsWith(matrix.host.platform, 'linux-')
         with:
           packages: |
@@ -151,6 +151,7 @@ jobs:
           echo ::group::Toolchain
           # Install updated llvm
           winget install --accept-source-agreements --silent -e --id=LLVM.LLVM
+          # This is the UCRT LLVM build. It seems better but v8's build system is heavily geared for clang-cl.
           # winget install --accept-source-agreements --silent -e --id=MartinStorsjo.LLVM-MinGW.UCRT
           # ls -d /c/Users/runneradmin/AppData/Local/Microsoft/WinGet/Packages/MartinStorsjo.LLVM-MinGW.UCRT_Microsoft.*/llvm-mingw-*-ucrt-*/bin >> "$GITHUB_PATH"
 

patches/build/00.windows-mingw-clang

@@ -65,6 +65,7 @@ if [ ${CLANG_BASE_PATH+-} ]; then
 		is_clang=true
 	)
 elif [ "$PLATFORM" = win32 ]; then
+	# clang-cl is used.
 	GN_ARGS+=(is_clang=true)
 else
 	# v8 drops support for gcc wow