Skip to content

Commit 10f4548

Browse files
committed
Add JDK 21 support for spark40 test and javadoc tasks
Signed-off-by: Sotaro Hikita <bering1814@gmail.com>
1 parent 541d02c commit 10f4548

3 files changed

Lines changed: 14 additions & 4 deletions

File tree

.github/workflows/build_spark_40.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,16 @@ jobs:
4343
- name: 'Setup: Java 17 env'
4444
run: echo "JAVA17_HOME=$JAVA_HOME" >> $GITHUB_ENV
4545

46+
- name: Set up JDK 21
47+
uses: actions/setup-java@v3
48+
with:
49+
distribution: 'temurin'
50+
java-version: '21'
51+
cache: 'gradle'
52+
53+
- name: 'Setup: Java 21 env'
54+
run: echo "JAVA21_HOME=$JAVA_HOME" >> $GITHUB_ENV
55+
4656
- name: Setup Gradle
4757
uses: gradle/gradle-build-action@v2
4858

spark/core/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ sparkVariants {
128128
dependsOn compileScala
129129
source(generatedJavaDirectory)
130130
if (variant.name.contains('spark40')) {
131-
executable = new File(System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/javadoc').absolutePath
131+
executable = new File(System.getenv('JAVA21_HOME') ?: System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/javadoc').absolutePath
132132
options.addStringOption('Xdoclint:none', '-quiet')
133133
failOnError = false
134134
}
@@ -170,7 +170,7 @@ if (JavaVersion.current() >= JavaVersion.VERSION_17) {
170170
// Spark 4.0 requires JDK 17+, override the runtime for spark40 test tasks
171171
tasks.withType(Test) { Test task ->
172172
if (task.name.contains("Spark40") || task.name.contains("spark40")) {
173-
task.executable = new File(System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/java').absolutePath
173+
task.executable = new File(System.getenv('JAVA21_HOME') ?: System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/java').absolutePath
174174
task.jvmArgs "--add-opens=java.base/java.io=ALL-UNNAMED"
175175
task.jvmArgs "--add-opens=java.base/java.nio=ALL-UNNAMED"
176176
task.jvmArgs "--add-opens=java.base/java.lang=ALL-UNNAMED"

spark/sql-40/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ sparkVariants {
162162
dependsOn compileScala
163163
source(generatedJavaDirectory)
164164
// Spark 4.0 jars are compiled with JDK 17, so javadoc must also run on JDK 17+
165-
executable = new File(System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/javadoc').absolutePath
165+
executable = new File(System.getenv('JAVA21_HOME') ?: System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/javadoc').absolutePath
166166
options.addStringOption('Xdoclint:none', '-quiet')
167167
failOnError = false
168168
}
@@ -175,7 +175,7 @@ sparkVariants {
175175

176176
// Spark 4.0 requires JDK 17+, override the runtime for all test tasks
177177
tasks.withType(Test) { Test task ->
178-
task.executable = new File(System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/java').absolutePath
178+
task.executable = new File(System.getenv('JAVA21_HOME') ?: System.getenv('JAVA17_HOME') ?: project.ext.runtimeJavaHome.toString(), 'bin/java').absolutePath
179179
task.jvmArgs "--add-opens=java.base/java.io=ALL-UNNAMED"
180180
task.jvmArgs "--add-opens=java.base/java.nio=ALL-UNNAMED"
181181
task.jvmArgs "--add-opens=java.base/java.lang=ALL-UNNAMED"

0 commit comments

Comments
 (0)