Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved the overflow for all screen resolutions - 5624 #5635

Closed
wants to merge 3 commits into from

Conversation

MUFFANUJ
Copy link
Contributor

@MUFFANUJ MUFFANUJ commented Jul 3, 2024

Description

This PR fixes #5624

Notes for Reviewers
Earlier it was breaking for all the resolutions below 788px, made the changes in order to make it responsive for all the possible resolution from 375px to 788px, also checked the behaviour its working as expected.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 3, 2024

🚀 Preview for commit fddafaa at: https://66853ee32b41ecf791db4862--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@MUFFANUJ Thanks for your initiative! Also, please note that we move in chronological order with issue assignments. Kindly wait to be assigned before working on an issue next time. We'll review your PR shortly. 🚀

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you shrink the font size a bit for smaller screens?

@MUFFANUJ
Copy link
Contributor Author

MUFFANUJ commented Jul 5, 2024

Looks good! Could you shrink the font size a bit for smaller screens?

Yeah sure will do it

@l5io
Copy link
Contributor

l5io commented Jul 7, 2024

🚀 Preview for commit 4919ca5 at: https://668abc71524ab7ba464c30e6--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@MUFFANUJ
Thank you for your contribution.
Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

@Ashparshp
Copy link
Contributor

@MUFFANUJ, Anything to update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Page Header Section Content Overflow on Narrow Screens
5 participants