Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Font Contrast for Saffron Color Card Based on Light/Dark Mode Preference #5941 #5970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajasurya-rjs
Copy link

Description

This PR addresses the low contrast issue with the "Saffron" color box by dynamically adjusting the font color based on the user's light or dark mode settings. The text color is now set to black for better readability when the "Saffron" background is used, regardless of the theme. The solution utilizes CSS media queries with prefers-color-scheme to ensure the appropriate font color is applied in both light and dark modes.

This PR fixes #5941
Screenshot 2024-10-03 at 9 56 46 PM

@l5io
Copy link
Contributor

l5io commented Oct 3, 2024

🚀 Preview for commit 2beff79 at: https://66fec9f605f377d417f5cf8a--layer5.netlify.app

@rajasurya-rjs
Copy link
Author

is there any thing which need to change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Brand] White text on Saffron color card is difficult to read
2 participants