[Handbook]Fix-6312 Extra spaces in the beginning of handbook pages in layer5 website #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview for commit 3bf39e8 at: https://67d7226ec4b82e56050dfa42--layer5.netlify.app |
Signed-off-by: gourav-k-shaw <[email protected]>
This reverts commit 439e517. Signed-off-by: gourav-k-shaw <[email protected]>
Signed-off-by: gourav-k-shaw <[email protected]>
gourav-k-shaw
force-pushed
the
fix-6312-layer5
branch
from
3bf39e8 to
885e580
Compare
|
🚀 Preview for commit 885e580 at: https://67d7268691f46de3070f984f--layer5.netlify.app |
sudhanshutech
suggested changes
Mar 17, 2025
| margin-left: 20rem; | ||
| } | ||
| display: flex; | ||
|
|
||
| @media screen and (min-width: 768px) and (max-height: 1145px) { | ||
| margin-top : -62vh ; | ||
| margin-top : -90vh ; |
There was a problem hiding this comment.
This doesn't looks good @gourav-k-shaw . It means we are just setting margins as required. In future something around this changes again we have to come and set the margin. Please use some other generic css so and use as less media queries you can. So we don't have to rely on changes around this component.
|
@gourav-k-shaw Thank you for your contribution! adding it as an agenda item to the meeting minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6312
Notes for Reviewers
Test Documentation: https://docs.google.com/document/d/1dvoVlz9rejB_a-9L90O7u6iwBM7H5TS3KgGJDVUP2rk/edit?usp=sharing
Signed commits