Skip to content

Commit 7b3e846

Browse files
committed
remove semantic-versioning
1 parent 2485e32 commit 7b3e846

File tree

4 files changed

+50
-79
lines changed

4 files changed

+50
-79
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
pull_request:
66
workflow_dispatch:
77

8-
# Permissions needed to push to gh-pages and create releases
8+
# Permissions needed to push to gh-pages
99
permissions:
1010
contents: write
1111
pages: write
@@ -79,35 +79,6 @@ jobs:
7979
cd ..
8080
npm test
8181
82-
release:
83-
needs: [openapi-client-generation, test]
84-
if: github.ref == 'refs/heads/main'
85-
runs-on: ubuntu-latest
86-
steps:
87-
- uses: actions/checkout@v4
88-
with:
89-
fetch-depth: 0
90-
91-
- name: Set up Node.js
92-
uses: actions/setup-node@v4
93-
with:
94-
node-version: '20.x'
95-
cache: 'npm'
96-
97-
- name: Install dependencies
98-
run: npm ci
99-
100-
- name: Configure Git
101-
run: |
102-
git config --global user.name "GitHub Actions"
103-
git config --global user.email "[email protected]"
104-
105-
- name: Release
106-
env:
107-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
108-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
109-
run: npm run release
110-
11182
docs:
11283
runs-on: ubuntu-latest
11384
permissions:

.releaserc.json

Lines changed: 0 additions & 9 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 48 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -89,34 +89,51 @@ constructor(options?: ClientOptions) {
8989
1. Have an npm account
9090
2. Be a member of the @lazydynamics organization
9191
3. Have the necessary permissions to publish packages
92-
4. Have a GitHub token with `repo` scope (for semantic-release)
93-
94-
### Publishing Process
95-
The package uses automated releases through GitHub Actions. When changes are merged into the `main` branch:
96-
1. The CI pipeline runs tests and verifies the OpenAPI client generation
97-
2. If all checks pass, semantic-release automatically:
98-
- Determines the next version number based on PR titles
99-
- Updates package.json
100-
- Creates a git tag
101-
- Publishes to npm
102-
- Creates a GitHub release
10392

104-
### Version Management
105-
The project uses semantic-release for automated version management. Version numbers are determined by PR titles:
106-
- `fix:` PRs trigger patch releases (1.0.0 → 1.0.1)
107-
- `feat:` PRs trigger minor releases (1.0.0 → 1.1.0)
108-
- PRs with `BREAKING CHANGE:` trigger major releases (1.0.0 → 2.0.0)
93+
### Publishing Steps
94+
1. Login to npm:
95+
```bash
96+
npm login
97+
```
10998

110-
Example PR titles:
111-
```
112-
fix: handle null values in response
113-
feat: add support for custom headers
114-
feat: add new API endpoint
99+
2. Build the package:
100+
```bash
101+
npm run build
102+
```
115103

116-
BREAKING CHANGE: remove deprecated method
117-
```
104+
3. Update the version in package.json:
105+
```bash
106+
npm version <patch|minor|major>
107+
```
108+
This will:
109+
- Update the version in package.json
110+
- Create a git tag
111+
- Commit the changes
118112

119-
Note: Releases only happen when changes are merged into the `main` branch. Make sure your PR titles follow the conventional commit format as they determine the version bump.
113+
4. Push the changes and tag:
114+
```bash
115+
git push && git push --tags
116+
```
117+
118+
5. Publish the package:
119+
```bash
120+
npm publish
121+
```
122+
123+
6. Create a GitHub release:
124+
- Go to the repository's Releases page on GitHub
125+
- Click "Create a new release"
126+
- Select the tag that was just created
127+
- Add release notes describing the changes
128+
- Click "Publish release"
129+
130+
Note: After publishing to npm, it's important to create a corresponding GitHub release to maintain consistency between npm and GitHub.
131+
132+
### Version Management
133+
Use semantic versioning for releases:
134+
- `npm version patch` for bug fixes (1.0.0 → 1.0.1)
135+
- `npm version minor` for new features (1.0.0 → 1.1.0)
136+
- `npm version major` for breaking changes (1.0.0 → 2.0.0)
120137

121138
## Code Style and Guidelines
122139

@@ -131,17 +148,13 @@ Note: Releases only happen when changes are merged into the `main` branch. Make
131148
1. Create a new branch for your feature/fix
132149
2. Make your changes
133150
3. Run tests (when available)
134-
4. Submit a pull request with a descriptive title following the conventional commit format
135-
136-
### PR Titles
137-
Follow conventional commits format for PR titles:
138-
- `feat:` for new features
139-
- `fix:` for bug fixes
140-
- `docs:` for documentation changes
141-
- `style:` for code style changes
142-
- `refactor:` for code refactoring
143-
- `test:` for test-related changes
144-
- `chore:` for maintenance tasks
151+
4. Submit a pull request
152+
153+
### Commit Messages
154+
Keep commit messages clear and descriptive:
155+
- Use present tense
156+
- Start with a capital letter
157+
- Be specific about what changed
145158

146159
## Getting Help
147160

package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
"docs:serve": "npx serve docs",
1515
"test": "node scripts/wait-for-server.js && jest",
1616
"test:watch": "jest --watch",
17-
"test:coverage": "jest --coverage",
18-
"release": "semantic-release"
17+
"test:coverage": "jest --coverage"
1918
},
2019
"repository": {
2120
"type": "git",
@@ -36,13 +35,10 @@
3635
},
3736
"devDependencies": {
3837
"@hey-api/openapi-ts": "^0.66.4",
39-
"@semantic-release/git": "^10.0.1",
40-
"@semantic-release/github": "^11.0.1",
4138
"@types/jest": "^29.5.14",
4239
"@types/node": "^20.11.24",
4340
"esbuild": "^0.20.2",
4441
"jest": "^29.7.0",
45-
"semantic-release": "^24.2.3",
4642
"ts-jest": "^29.3.2",
4743
"typedoc": "^0.28.2",
4844
"typescript": "^5.3.3"

0 commit comments

Comments
 (0)