Merge pull request #410 from lazzyfu/dev

Dev

Author: lazzyfu

.codex/skills/ant-design-vue/SKILL.md

@@ -1,4 +1,4 @@
 interface:
-  display_name: "Ant Design Vue 统一规范"
-  short_description: "统一 Ant Design Vue 页面布局、间距、圆角与按钮规范"
-  default_prompt: "请基于 Vue3 + Ant Design Vue 4.x 先输出规范化 UI 方案（布局、组件映射、一致性检查），再给实现建议；严格遵守全局间距/圆角 token 和按钮统一 middle 规则。"
+    display_name: "Ant Design Vue 统一规范"
+    short_description: "统一 Ant Design Vue 页面布局、间距、圆角与按钮规范"
+    default_prompt: "请基于 Vue3 + Ant Design Vue 4.x 先输出规范化 UI 方案（布局、组件映射、一致性检查），再给实现建议；严格遵守全局间距/圆角 token 和按钮统一 middle 规则。"

.codex/skills/ant-design-vue/agents/openai.yaml

@@ -3,6 +3,7 @@ package services
 import (
 	"errors"
 	"fmt"
+	netmail "net/mail"
 	"net/url"
 	"strings"
 	"time"
@@ -113,15 +114,15 @@ func (s *AdminTestNotifyConfigService) Run() error {
 	if err != nil {
 		return fmt.Errorf("加载通知配置失败: %w", err)
 	}
+	if err := validateRuntimeChannelConfig(s.Channel, runtimeCfg); err != nil {
+		return err
+	}
 
 	now := time.Now().Format("2006-01-02 15:04:05")
 	baseMsg := fmt.Sprintf("您好，这是一条 GoInsight 消息通知测试。\n时间：%s", now)
 
 	switch s.Channel {
 	case "wechat":
-		if !runtimeCfg.Wechat.Enable {
-			return errors.New("请先启用企业微信通知后再测试")
-		}
 		wechatNotifier := notifier.NewWechatNotifier(notifier.WechatNotifierConfig{
 			Webhook: runtimeCfg.Wechat.Webhook,
 		})
@@ -131,9 +132,6 @@ func (s *AdminTestNotifyConfigService) Run() error {
 		return nil
 
 	case "dingtalk":
-		if !runtimeCfg.DingTalk.Enable {
-			return errors.New("请先启用钉钉通知后再测试")
-		}
 		dingtalkNotifier := notifier.NewDingTalkNotifier(notifier.DingTalkNotifierConfig{
 			Webhook: runtimeCfg.DingTalk.Webhook,
 		})
@@ -147,10 +145,6 @@ func (s *AdminTestNotifyConfigService) Run() error {
 		return nil
 
 	case "mail":
-		if !runtimeCfg.Mail.Enable {
-			return errors.New("请先启用邮件通知后再测试")
-		}
-
 		var user userModels.InsightUsers
 		if err := global.App.DB.Table("insight_users").Where("username = ?", username).Take(&user).Error; err != nil {
 			return fmt.Errorf("邮件测试发送失败: 查询用户邮箱失败(%w)", err)
@@ -175,6 +169,60 @@ func (s *AdminTestNotifyConfigService) Run() error {
 	}
 }
 
+func validateRuntimeChannelConfig(channel string, runtimeCfg *notifier.RuntimeNotifyConfig) error {
+	if runtimeCfg == nil {
+		return errors.New("通知配置不存在")
+	}
+
+	switch channel {
+	case "wechat":
+		if !runtimeCfg.Wechat.Enable {
+			return errors.New("请先启用企业微信通知后再测试")
+		}
+		if !isValidHTTPURL(runtimeCfg.Wechat.Webhook) {
+			return errors.New("企业微信 Webhook 配置不正确，请先保存合法地址")
+		}
+		return nil
+
+	case "dingtalk":
+		if !runtimeCfg.DingTalk.Enable {
+			return errors.New("请先启用钉钉通知后再测试")
+		}
+		if !isValidHTTPURL(runtimeCfg.DingTalk.Webhook) {
+			return errors.New("钉钉 Webhook 配置不正确，请先保存合法地址")
+		}
+		if strings.TrimSpace(runtimeCfg.DingTalk.Keywords) == "" {
+			return errors.New("钉钉关键字不能为空，请先完善后再测试")
+		}
+		return nil
+
+	case "mail":
+		if !runtimeCfg.Mail.Enable {
+			return errors.New("请先启用邮件通知后再测试")
+		}
+		mailUsername := strings.TrimSpace(runtimeCfg.Mail.Username)
+		if mailUsername == "" {
+			return errors.New("邮件发件账号不能为空，请先完善后再测试")
+		}
+		if _, err := netmail.ParseAddress(mailUsername); err != nil {
+			return errors.New("邮件发件账号格式不正确，请先完善后再测试")
+		}
+		if strings.TrimSpace(runtimeCfg.Mail.Host) == "" {
+			return errors.New("邮件 SMTP 主机不能为空，请先完善后再测试")
+		}
+		if runtimeCfg.Mail.Port < 1 || runtimeCfg.Mail.Port > 65535 {
+			return errors.New("邮件 SMTP 端口范围必须为 1-65535")
+		}
+		if strings.TrimSpace(runtimeCfg.Mail.Password) == "" {
+			return errors.New("邮件 SMTP 密码不能为空，请先完善后再测试")
+		}
+		return nil
+
+	default:
+		return errors.New("不支持的测试渠道")
+	}
+}
+
 func normalizeNoticeURL(raw string) string {
 	return strings.TrimRight(strings.TrimSpace(raw), "/")
 }
@@ -202,10 +250,16 @@ func validateNotifyConfigForSave(form *forms.AdminUpdateNotifyConfigForm, hasSto
 	if form.Wechat.Enable && form.Wechat.Webhook == "" {
 		return errors.New("启用企业微信通知时，Webhook 不能为空")
 	}
+	if form.Wechat.Enable && !isValidHTTPURL(form.Wechat.Webhook) {
+		return errors.New("启用企业微信通知时，Webhook 地址格式不正确")
+	}
 
 	if form.DingTalk.Enable && form.DingTalk.Webhook == "" {
 		return errors.New("启用钉钉通知时，Webhook 不能为空")
 	}
+	if form.DingTalk.Enable && !isValidHTTPURL(form.DingTalk.Webhook) {
+		return errors.New("启用钉钉通知时，Webhook 地址格式不正确")
+	}
 	if form.DingTalk.Enable && form.DingTalk.Keywords == "" {
 		return errors.New("启用钉钉通知时，关键字不能为空")
 	}
@@ -214,6 +268,9 @@ func validateNotifyConfigForSave(form *forms.AdminUpdateNotifyConfigForm, hasSto
 		if form.Mail.Username == "" {
 			return errors.New("启用邮件通知时，用户名不能为空")
 		}
+		if _, err := netmail.ParseAddress(form.Mail.Username); err != nil {
+			return errors.New("启用邮件通知时，用户名必须是合法邮箱")
+		}
 		if form.Mail.Host == "" {
 			return errors.New("启用邮件通知时，SMTP 主机不能为空")
 		}

backend/internal/common/services/notify.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	"github.com/lazzyfu/goinsight/internal/common/forms"
+	"github.com/lazzyfu/goinsight/pkg/notifier"
 )
 
 func buildValidNotifyForm() *forms.AdminUpdateNotifyConfigForm {
@@ -59,6 +60,15 @@ func TestValidateNotifyConfigForSave(t *testing.T) {
 		}
 	})
 
+	t.Run("wechat enabled with invalid webhook", func(t *testing.T) {
+		form := buildValidNotifyForm()
+		form.Wechat.Enable = true
+		form.Wechat.Webhook = "not-a-url"
+		if err := validateNotifyConfigForSave(form, false); err == nil {
+			t.Fatal("expected validation error")
+		}
+	})
+
 	t.Run("dingtalk enabled without webhook", func(t *testing.T) {
 		form := buildValidNotifyForm()
 		form.DingTalk.Enable = true
@@ -67,6 +77,16 @@ func TestValidateNotifyConfigForSave(t *testing.T) {
 		}
 	})
 
+	t.Run("dingtalk enabled with invalid webhook", func(t *testing.T) {
+		form := buildValidNotifyForm()
+		form.DingTalk.Enable = true
+		form.DingTalk.Webhook = "invalid-webhook"
+		form.DingTalk.Keywords = "GoInsight"
+		if err := validateNotifyConfigForSave(form, false); err == nil {
+			t.Fatal("expected validation error")
+		}
+	})
+
 	t.Run("dingtalk enabled without keywords", func(t *testing.T) {
 		form := buildValidNotifyForm()
 		form.DingTalk.Enable = true
@@ -95,6 +115,18 @@ func TestValidateNotifyConfigForSave(t *testing.T) {
 		}
 	})
 
+	t.Run("mail enabled with invalid username email", func(t *testing.T) {
+		form := buildValidNotifyForm()
+		form.Mail.Enable = true
+		form.Mail.Username = "not-an-email"
+		form.Mail.Host = "smtp.example.com"
+		form.Mail.Password = "secret"
+		form.Mail.Port = 465
+		if err := validateNotifyConfigForSave(form, false); err == nil {
+			t.Fatal("expected validation error")
+		}
+	})
+
 	t.Run("mail enabled with invalid port", func(t *testing.T) {
 		form := buildValidNotifyForm()
 		form.Mail.Enable = true
@@ -131,3 +163,51 @@ func TestValidateNotifyConfigForSave(t *testing.T) {
 		}
 	})
 }
+
+func buildValidRuntimeNotifyConfig() *notifier.RuntimeNotifyConfig {
+	cfg := &notifier.RuntimeNotifyConfig{}
+	cfg.Wechat.Enable = true
+	cfg.Wechat.Webhook = "https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key=demo"
+	cfg.DingTalk.Enable = true
+	cfg.DingTalk.Webhook = "https://oapi.dingtalk.com/robot/send?access_token=demo"
+	cfg.DingTalk.Keywords = "GoInsight"
+	cfg.Mail.Enable = true
+	cfg.Mail.Username = "ops@example.com"
+	cfg.Mail.Password = "secret"
+	cfg.Mail.Host = "smtp.example.com"
+	cfg.Mail.Port = 465
+	return cfg
+}
+
+func TestValidateRuntimeChannelConfig(t *testing.T) {
+	t.Run("valid wechat config", func(t *testing.T) {
+		cfg := buildValidRuntimeNotifyConfig()
+		if err := validateRuntimeChannelConfig("wechat", cfg); err != nil {
+			t.Fatalf("unexpected error: %v", err)
+		}
+	})
+
+	t.Run("wechat enabled but webhook empty", func(t *testing.T) {
+		cfg := buildValidRuntimeNotifyConfig()
+		cfg.Wechat.Webhook = ""
+		if err := validateRuntimeChannelConfig("wechat", cfg); err == nil {
+			t.Fatal("expected validation error")
+		}
+	})
+
+	t.Run("dingtalk enabled but keywords empty", func(t *testing.T) {
+		cfg := buildValidRuntimeNotifyConfig()
+		cfg.DingTalk.Keywords = ""
+		if err := validateRuntimeChannelConfig("dingtalk", cfg); err == nil {
+			t.Fatal("expected validation error")
+		}
+	})
+
+	t.Run("mail enabled but password empty", func(t *testing.T) {
+		cfg := buildValidRuntimeNotifyConfig()
+		cfg.Mail.Password = ""
+		if err := validateRuntimeChannelConfig("mail", cfg); err == nil {
+			t.Fatal("expected validation error")
+		}
+	})
+}

backend/internal/common/services/notify_test.go

@@ -1,11 +1,14 @@
-<!doctype html>
-<html lang="en">
-<head>
-  <meta charset="utf-8">
-  <meta name="viewport" content="width=device-width,initial-scale=1">
-  <title>GoInsight</title>
-</head>
-<body>
-  <p>Frontend assets are not built yet. Run `cd www && npm install && npm run build` first.</p>
-</body>
+<!DOCTYPE html>
+<html lang="">
+  <head>
+    <meta charset="UTF-8">
+    <link rel="icon" href="/favicon.ico">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <title>数据库工单平台</title>
+    <script type="module" crossorigin src="/assets/index-KL7fv5kM.js"></script>
+    <link rel="stylesheet" crossorigin href="/assets/index-QwWTY4TQ.css">
+  </head>
+  <body>
+    <div id="app"></div>
+  </body>
 </html>