Skip to content

Commit ae58641

Browse files
authored
changed tolerance and updated reference (#4066)
1 parent da1cec1 commit ae58641

10 files changed

Lines changed: 99 additions & 81 deletions

Buildings/Resources/ReferenceResults/Dymola/Buildings_ThermalZones_EnergyPlus_9_6_0_Examples_SmallOffice_ASHRAE2006Winter.txt

Lines changed: 22 additions & 22 deletions
Large diffs are not rendered by default.

Buildings/Resources/ReferenceResults/Dymola/Buildings_ThermalZones_EnergyPlus_9_6_0_Examples_SmallOffice_IdealHeatingCoolingSpring.txt

Lines changed: 16 additions & 16 deletions
Large diffs are not rendered by default.

Buildings/Resources/ReferenceResults/Dymola/Buildings_ThermalZones_EnergyPlus_9_6_0_Examples_SmallOffice_IdealHeatingCoolingSummer.txt

Lines changed: 18 additions & 18 deletions
Large diffs are not rendered by default.

Buildings/Resources/ReferenceResults/Dymola/Buildings_ThermalZones_EnergyPlus_9_6_0_Examples_SmallOffice_IdealHeatingCoolingWinter.txt

Lines changed: 18 additions & 18 deletions
Large diffs are not rendered by default.

Buildings/Resources/Scripts/Dymola/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingSpring.mos

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSpring", startTime=7344000, stopTime=7776000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingSpring");
1+
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSpring", startTime=7344000, stopTime=7776000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingSpring");
22
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
33
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
44
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});

Buildings/Resources/Scripts/Dymola/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingSummer.mos

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSummer", startTime=16848000, stopTime=17280000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingSummer");
1+
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingSummer", startTime=16848000, stopTime=17280000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingSummer");
22
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
33
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
44
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});

Buildings/Resources/Scripts/Dymola/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingWinter.mos

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingWinter", startTime=432000, stopTime=864000, method="Radau", tolerance=1e-06, resultFile="IdealHeatingCoolingWinter");
1+
simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.IdealHeatingCoolingWinter", startTime=432000, stopTime=864000, method="Radau", tolerance=1e-07, resultFile="IdealHeatingCoolingWinter");
22
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.TAirCor", "flo.TAirSou", "flo.TAirNor", "flo.TAirEas", "flo.TAirWes"}, range={5.0, 10.0, 0.0, 40.0}, grid=true, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"degC", "degC", "degC", "degC", "degC"});
33
createPlot(id=1, position={15, 15, 1496, 1040}, y={"hea[1].conPID.y", "hea[2].conPID.y", "hea[3].conPID.y", "hea[4].conPID.y", "hea[5].conPID.y"}, range={5.0, 10.0, -1.0, 2.0}, grid=true, subPlot=102, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d");
44
createPlot(id=1, position={15, 15, 1496, 1040}, y={"flo.sou.heaPorAir.Q_flow", "flo.eas.heaPorAir.Q_flow", "flo.nor.heaPorAir.Q_flow", "flo.wes.heaPorAir.Q_flow", "flo.cor.heaPorAir.Q_flow"}, range={5.0, 10.0, -10000.0, 20000.0}, grid=true, subPlot=104, colors={{28,108,200}, {238,46,47}, {0,140,72}, {217,67,180}, {0,0,0}}, timeUnit="d", displayUnits={"W", "W", "W", "W", "W"});

Buildings/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingSpring.mo

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ model IdealHeatingCoolingSpring
88
experiment(
99
StartTime=7344000,
1010
StopTime=7776000,
11-
Tolerance=1e-06),
11+
Tolerance=1e-07),
1212
Icon(
1313
coordinateSystem(
1414
extent={{-100,-100},{100,100}},
@@ -25,6 +25,12 @@ but configured for simulation of a few days in summer.
2525
revisions="<html>
2626
<ul>
2727
<li>
28+
November 25, 2024, by Jianjun Hu:<br/>
29+
Changed tolerance to 1e-07.
30+
This is for
31+
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
32+
</li>
33+
<li>
2834
March 5, 2021, by Michael Wetter:<br/>
2935
First implementation.
3036
</li>

Buildings/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingSummer.mo

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ model IdealHeatingCoolingSummer
88
experiment(
99
StartTime=16848000,
1010
StopTime=17280000,
11-
Tolerance=1e-06),
11+
Tolerance=1e-07),
1212
Icon(
1313
coordinateSystem(
1414
extent={{-100,-100},{100,100}},
@@ -25,6 +25,12 @@ but configured for simulation of a few days in summer.
2525
revisions="<html>
2626
<ul>
2727
<li>
28+
November 25, 2024, by Jianjun Hu:<br/>
29+
Changed tolerance to 1e-07.
30+
This is for
31+
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
32+
</li>
33+
<li>
2834
March 5, 2021, by Michael Wetter:<br/>
2935
First implementation.
3036
</li>

Buildings/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingWinter.mo

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ equation
7373
connect(QCoo_flow.y,ECoo.u)
7474
annotation (Line(points={{-8,160},{-2,160}},color={0,0,127}));
7575
connect(QCoo_flow.u[1:5],coo.Q_flow)
76-
annotation (Line(points={{-32,158.4},{-46,158.4},{-46,146},{-58,146}},color={0,0,127}));
76+
annotation (Line(points={{-32,160.8},{-46,160.8},{-46,146},{-58,146}},color={0,0,127}));
7777
annotation (
7878
__Dymola_Commands(
7979
file="modelica://Buildings/Resources/Scripts/Dymola/ThermalZones/EnergyPlus_9_6_0/Examples/SmallOffice/IdealHeatingCoolingWinter.mos" "Simulate and plot"),
8080
experiment(
8181
StartTime=432000,
8282
StopTime=864000,
83-
Tolerance=1e-06),
83+
Tolerance=1e-07),
8484
Documentation(
8585
info="<html>
8686
<p>
@@ -91,6 +91,12 @@ but an ideal heating/cooling device that exactly meets the load.
9191
revisions="<html>
9292
<ul>
9393
<li>
94+
November 25, 2024, by Jianjun Hu:<br/>
95+
Changed tolerance to 1e-07.
96+
This is for
97+
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4063\">issue #4063</a>.
98+
</li>
99+
<li>
94100
March 4, 2021, by Michael Wetter:<br/>
95101
First implementation.<br/>
96102
This is for

0 commit comments

Comments
 (0)