Added nominal attribute to integrator of PI controller

mwetter · mwetter · commit e9501a4ecfab · 2026-04-13T11:22:05.000-07:00
This merges IBPSA, issue 2106
diff --git a/Buildings/Controls/OBC/CDL/Reals/PID.mo b/Buildings/Controls/OBC/CDL/Reals/PID.mo
@@ -60,6 +60,7 @@ block PID
     "Gain for proportional control action"
     annotation (Placement(transformation(extent={{-50,130},{-30,150}})));
   Buildings.Controls.OBC.CDL.Reals.IntegratorWithReset I(
+    y(nominal=max(abs(yMax), abs(yMin))),
     final k=k/Ti,
     final y_start=xi_start) if with_I
     "Integral term"
@@ -479,6 +480,12 @@ American Society of Heating Refrigerating and Air-Conditioning Engineers Inc. At
       revisions="<html>
 <ul>
 <li>
+April 13, 2026, by Michael Wetter:<br/>
+Added value for <coded>nominal</code> attribute for integrator state <code>I.y</code><br/>
+This is for
+<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/2106\">IBPSA, issue 2106</a>.
+</li>
+<li>
 October 23, 2023, by Michael Wetter:<br/>
 Added value of control output <code>y</code> to icon.
 </li>
diff --git a/Buildings/Controls/OBC/CDL/Reals/PIDWithReset.mo b/Buildings/Controls/OBC/CDL/Reals/PIDWithReset.mo
@@ -65,6 +65,7 @@ block PIDWithReset
     "Proportional action"
     annotation (Placement(transformation(extent={{-50,130},{-30,150}})));
   Buildings.Controls.OBC.CDL.Reals.IntegratorWithReset I(
+    y(nominal=max(abs(yMax), abs(yMin))),
     final k=k/Ti,
     final y_start=xi_start) if with_I
     "Integral term"
@@ -482,6 +483,12 @@ American Society of Heating Refrigerating and Air-Conditioning Engineers Inc. At
       revisions="<html>
 <ul>
 <li>
+April 13, 2026, by Michael Wetter:<br/>
+Added value for <coded>nominal</code> attribute for integrator state <code>I.y</code><br/>
+This is for
+<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/2106\">IBPSA, issue 2106</a>.
+</li>
+<li>
 October 23, 2023, by Michael Wetter:<br/>
 Added value of control output <code>y</code> to icon.
 </li>
