Add type to class constants

Author: Slamdunk

src/Signer/Blake2b.php

@@ -11,7 +11,7 @@
 
 final readonly class Blake2b implements Signer
 {
-    private const MINIMUM_KEY_LENGTH_IN_BITS = 256;
+    private const int MINIMUM_KEY_LENGTH_IN_BITS = 256;
 
     public function algorithmId(): string
     {

src/Signer/Ecdsa/MultibyteStringConverter.php

@@ -33,13 +33,13 @@
  */
 final readonly class MultibyteStringConverter implements SignatureConverter
 {
-    private const ASN1_SEQUENCE          = '30';
-    private const ASN1_INTEGER           = '02';
-    private const ASN1_MAX_SINGLE_BYTE   = 128;
-    private const ASN1_LENGTH_2BYTES     = '81';
-    private const ASN1_BIG_INTEGER_LIMIT = '7f';
-    private const ASN1_NEGATIVE_INTEGER  = '00';
-    private const BYTE_SIZE              = 2;
+    private const string ASN1_SEQUENCE          = '30';
+    private const string ASN1_INTEGER           = '02';
+    private const int ASN1_MAX_SINGLE_BYTE      = 128;
+    private const string ASN1_LENGTH_2BYTES     = '81';
+    private const string ASN1_BIG_INTEGER_LIMIT = '7f';
+    private const string ASN1_NEGATIVE_INTEGER  = '00';
+    private const int BYTE_SIZE                 = 2;
 
     public function toAsn1(string $points, int $length): string
     {

src/Signer/OpenSSL.php

@@ -26,7 +26,7 @@
 
 abstract readonly class OpenSSL implements Signer
 {
-    protected const KEY_TYPE_MAP = [
+    protected const array KEY_TYPE_MAP = [
         OPENSSL_KEYTYPE_RSA => 'RSA',
         OPENSSL_KEYTYPE_DSA => 'DSA',
         OPENSSL_KEYTYPE_DH => 'DH',

src/Signer/Rsa.php

@@ -7,7 +7,7 @@
 
 abstract readonly class Rsa extends OpenSSL
 {
-    private const MINIMUM_KEY_LENGTH = 2048;
+    private const int MINIMUM_KEY_LENGTH = 2048;
 
     final public function sign(string $payload, Key $key): string
     {

src/SodiumBase64Polyfill.php

@@ -18,10 +18,10 @@
 /** @internal */
 final readonly class SodiumBase64Polyfill
 {
-    public const SODIUM_BASE64_VARIANT_ORIGINAL            = 1;
-    public const SODIUM_BASE64_VARIANT_ORIGINAL_NO_PADDING = 3;
-    public const SODIUM_BASE64_VARIANT_URLSAFE             = 5;
-    public const SODIUM_BASE64_VARIANT_URLSAFE_NO_PADDING  = 7;
+    public const int SODIUM_BASE64_VARIANT_ORIGINAL            = 1;
+    public const int SODIUM_BASE64_VARIANT_ORIGINAL_NO_PADDING = 3;
+    public const int SODIUM_BASE64_VARIANT_URLSAFE             = 5;
+    public const int SODIUM_BASE64_VARIANT_URLSAFE_NO_PADDING  = 7;
 
     /** @return ($decoded is non-empty-string ? non-empty-string : string) */
     public static function bin2base64(string $decoded, int $variant): string

src/Token/Parser.php

@@ -17,7 +17,7 @@
 
 final readonly class Parser implements ParserInterface
 {
-    private const MICROSECOND_PRECISION = 6;
+    private const int MICROSECOND_PRECISION = 6;
 
     public function __construct(private Decoder $decoder)
     {

src/Token/RegisteredClaims.php

@@ -10,7 +10,7 @@
  */
 interface RegisteredClaims
 {
-    public const ALL = [
+    public const array ALL = [
         self::AUDIENCE,
         self::EXPIRATION_TIME,
         self::ID,
@@ -20,7 +20,7 @@ interface RegisteredClaims
         self::SUBJECT,
     ];
 
-    public const DATE_CLAIMS = [
+    public const array DATE_CLAIMS = [
         self::ISSUED_AT,
         self::NOT_BEFORE,
         self::EXPIRATION_TIME,
@@ -31,47 +31,47 @@ interface RegisteredClaims
      *
      * @see https://tools.ietf.org/html/rfc7519#section-4.1.3
      */
-    public const AUDIENCE = 'aud';
+    public const string AUDIENCE = 'aud';
 
     /**
      * Identifies the expiration time on or after which the JWT MUST NOT be accepted for processing
      *
      * @see https://tools.ietf.org/html/rfc7519#section-4.1.4
      */
-    public const EXPIRATION_TIME = 'exp';
+    public const string EXPIRATION_TIME = 'exp';
 
     /**
      * Provides a unique identifier for the JWT
      *
      * @see https://tools.ietf.org/html/rfc7519#section-4.1.7
      */
-    public const ID = 'jti';
+    public const string ID = 'jti';
 
     /**
      * Identifies the time at which the JWT was issued
      *
      * @see https://tools.ietf.org/html/rfc7519#section-4.1.6
      */
-    public const ISSUED_AT = 'iat';
+    public const string ISSUED_AT = 'iat';
 
     /**
      * Identifies the principal that issued the JWT
      *
      * @see https://tools.ietf.org/html/rfc7519#section-4.1.1
      */
-    public const ISSUER = 'iss';
+    public const string ISSUER = 'iss';
 
     /**
      * Identifies the time before which the JWT MUST NOT be accepted for processing
      *
      * https://tools.ietf.org/html/rfc7519#section-4.1.5
      */
-    public const NOT_BEFORE = 'nbf';
+    public const string NOT_BEFORE = 'nbf';
 
     /**
      * Identifies the principal that is the subject of the JWT.
      *
      * https://tools.ietf.org/html/rfc7519#section-4.1.2
      */
-    public const SUBJECT = 'sub';
+    public const string SUBJECT = 'sub';
 }

tests/Benchmark/AlgorithmsBench.php

@@ -14,16 +14,16 @@
 #[Bench\Warmup(3)]
 abstract class AlgorithmsBench
 {
-    private const SUPPORTED_ALGORITHMS = [
+    private const array SUPPORTED_ALGORITHMS = [
         'hmac' => ['HS256', 'HS384', 'HS512'],
         'rsa' => ['RS256', 'RS384', 'RS512'],
         'ecdsa' => ['ES256', 'ES384', 'ES512'],
         'eddsa' => ['EdDSA'],
         'blake2b' => ['BLAKE2B'],
     ];
 
-    protected const PAYLOAD = "It\xe2\x80\x99s a dangerous business, Frodo, going out your door. You step onto the road"
-        . ", and if you don't keep your feet, there\xe2\x80\x99s no knowing where you might be swept"
+    protected const string PAYLOAD = "It\xe2\x80\x99s a dangerous business, Frodo, going out your door. You step "
+        . " onto the road, and if you don't keep your feet, there\xe2\x80\x99s no knowing where you might be swept"
         . ' off to.';
 
     #[Bench\Subject]

tests/Signer/Blake2bTest.php

@@ -18,12 +18,12 @@
 #[PHPUnit\UsesClass(SodiumBase64Polyfill::class)]
 final class Blake2bTest extends TestCase
 {
-    private const KEY_ONE                    = 'GOu4rLyVCBxmxP+sbniU68ojAja5PkRdvv7vNvBCqDQ=';
-    private const KEY_TWO                    = 'Pu7gywseH+R5HLIWnMll4rEg1ltjUPq/P9WwEzAsAb8=';
-    private const CONTENTS                   = 'test';
-    private const EXPECTED_HASH_WITH_KEY_ONE = '/TG5kmkav/YGl3I9uQiv4cm1VN6Q0zPCom4G7+p74JU=';
+    private const string KEY_ONE                    = 'GOu4rLyVCBxmxP+sbniU68ojAja5PkRdvv7vNvBCqDQ=';
+    private const string KEY_TWO                    = 'Pu7gywseH+R5HLIWnMll4rEg1ltjUPq/P9WwEzAsAb8=';
+    private const string CONTENTS                   = 'test';
+    private const string EXPECTED_HASH_WITH_KEY_ONE = '/TG5kmkav/YGl3I9uQiv4cm1VN6Q0zPCom4G7+p74JU=';
 
-    private const SHORT_KEY = 'PIBQuM5PopdMxtmTWmyvNA==';
+    private const string SHORT_KEY = 'PIBQuM5PopdMxtmTWmyvNA==';
 
     private InMemory $keyOne;
     private InMemory $keyTwo;

tests/SodiumBase64PolyfillTest.php

@@ -20,8 +20,8 @@
 #[PHPUnit\UsesClass(CannotDecodeContent::class)]
 final class SodiumBase64PolyfillTest extends TestCase
 {
-    private const B64    = 'I+o2tVq8ynY=';
-    private const B64URL = 'lZ-2HIl9dTz_Oy0nAb-2gvKdG0jhHJ36XB2rWAKj8Uo=';
+    private const string B64    = 'I+o2tVq8ynY=';
+    private const string B64URL = 'lZ-2HIl9dTz_Oy0nAb-2gvKdG0jhHJ36XB2rWAKj8Uo=';
 
     #[PHPUnit\Test]
     public function constantsMatchExtensionOnes(): void