Recreate Test Apps for Rails 8 (#17)

* Create test app and update .gitignores

* Add gems and Devise generator

* Add devise_invitable

* After devise generators

* Remove files that shouldn't have been tracked

* DB for Devise

* Add home_controller

* Updates to contributing

* .gitignore flailing

* Run devise_bootstrap_form generator

* Move Rails 8.0 app to rails_app

* Fix nested .gitignore

* Generator look for right manifest
This may be should just remove the import, as we don't need our
styles anymore?

* User double-quotes

* Templates without wrapper nor styles

* Test app with import
Also maybe not needed/valid?

* Reminder to use local gem from parent directory source

* Spanish before adding home

* Add root page

* Move Spanish test app

* Update CI matrix

* Get rid of omakase from test apps and other rubocop fixes

Author: lcreid

.devcontainer.json

@@ -0,0 +1,41 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/docker-existing-docker-compose
+{
+	"name": "devise-bootstrap-form",
+
+	// Update the 'dockerComposeFile' list if you have more compose files or use different names.
+	"dockerComposeFile": [
+		"compose.yml",
+		"compose.override.yml"
+	],
+
+	// The 'service' property is the name of the service for the container that VS Code should
+	// use. Update this value and .devcontainer/docker-compose.yml to the real service name.
+	"service": "web",
+
+	// The optional 'workspaceFolder' property is the path VS Code should open by default when
+	// connected. This is typically a file mount in .devcontainer/docker-compose.yml
+	"workspaceFolder": "/app"
+	// "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}"
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Uncomment the next line if you want start specific services in your Docker Compose config.
+	// "runServices": [],
+
+	// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
+	// "shutdownAction": "none",
+
+	// Uncomment the next line to run commands after the container is created.
+	// "postCreateCommand": "cat /etc/os-release",
+
+	// Configure tool-specific properties.
+	// "customizations": {},
+
+	// Uncomment to connect as an existing user other than the container default. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "devcontainer"
+}

.github/workflows/ruby.yml

@@ -11,30 +11,17 @@ jobs:
       - uses: actions/checkout@v2
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7.2
+          ruby-version: 3.2
           bundler-cache: true
-      - name: Danger
-        if: ${{ github.event_name == 'pull_request' }}
-        run: |
-          gem install danger
-          export DANGER_GITHUB_API_TOKEN=${{ github.token }}
-          danger
       - name: Rubocop
         run: bundle exec rubocop --auto-correct
   Test:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: [ '3.1', '3.0', '2.7', '2.6' ]
-        gemfile: [ '7.0', '6.1', '6.0', '5.2', 'edge' ]
-        exclude:
-          - { ruby-version: '3.1', gemfile: "6.1" } # Triggers some deprecations that might never get fixed
-          - { ruby-version: '3.1', gemfile: "6.0" }
-          - { ruby-version: '3.1', gemfile: "5.2" }
-          - { ruby-version: '3.0', gemfile: "5.2" }
-          - { ruby-version: '2.6', gemfile: "edge" }
-          - { ruby-version: '2.6', gemfile: "7.0" }
+        ruby-version: [ '3.4', '3.3', '3.2' ]
+        gemfile: [ '8.0', '7.2', '7.1', '7.0', 'edge' ]
     steps:
       - uses: actions/checkout@v2
       - name: Set up Ruby

.gitignore

@@ -29,4 +29,15 @@
 # For Alpine images
 .ash_history
 
+.npm/
+node_modules/
+
+.ssh/
+.gnupg/
+.gitconfig
+
 vendor/bundle
+
+.vscode-server/
+
+compose.override.yml

.rubocop.yml

@@ -44,44 +44,18 @@ Layout/LineLength:
   # The IgnoreCopDirectives option causes the LineLength rule to ignore cop
   # directives like '# rubocop: enable ...' when calculating a line's length.
   IgnoreCopDirectives: true
-  # The IgnoredPatterns option is a list of !ruby/regexp and/or string
-  # elements. Strings will be converted to Regexp objects. A line that matches
-  # any regular expression listed in this option will be ignored by LineLength.
-  IgnoredPatterns: []
+  # AllowedPatterns: []
 
-# Rails 5 only requires 2.2.2.
 AllCops:
   NewCops: enable
   DisplayCopNames: true
   DisplayStyleGuide: true
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 3.2
   Exclude:
     - Capfile
     - Gemfile
-    - "test/rails_app/bin/**/*"
-    - "test/rails_app/config/**/*"
-    - test/rails_app/config.ru
-    - "test/rails_app/db/**/*"
-    - "test/rails_app/log/**/*"
-    - "test/rails_app/tmp/**/*"
-    - "test/rails_app/vendor/**/*"
-    - "test/rails_app/node_modules/**/*"
-    - "test/rails_app/bower_components/**/*"
-    - test/rails_app/Gemfile
-    - test/rails_app/Guardfile
-    - test/rails_app/Rakefile
-    - "test/es_rails_app/bin/**/*"
-    - "test/es_rails_app/config/**/*"
-    - test/es_rails_app/config.ru
-    - "test/es_rails_app/db/**/*"
-    - "test/es_rails_app/log/**/*"
-    - "test/es_rails_app/tmp/**/*"
-    - "test/es_rails_app/vendor/**/*"
-    - "test/es_rails_app/node_modules/**/*"
-    - "test/es_rails_app/bower_components/**/*"
-    - test/es_rails_app/Gemfile
-    - test/es_rails_app/Guardfile
-    - test/es_rails_app/Rakefile
+    - test/es_rails_app/**/*
+    - test/rails_app/**/*
     - vendor/bundle/**/*
 
 Metrics/BlockLength:
@@ -99,9 +73,3 @@ Metrics/ClassLength:
 Metrics/MethodLength:
   Exclude:
     - test/**/*.rb
-
-# TODO: Remove this when minimum Ruby is 2.3.
-Layout/HeredocIndentation:
-  Exclude:
-    - Dangerfile
-    - devise-bootstrap-form.gemspec

CONTRIBUTING.md

@@ -21,7 +21,7 @@ To use the `devise-bootstrap-form` gem in a test app:
 cd test/rails_app # or cd test/es_rails_app
 # Generate the view in the test app
 rails g devise:views:bootstrap_form
-rails s -b 0.0.0.0 &
+bin/dev
 # Navigate to localhost:3000/people/sign_in
 ```
 
@@ -30,7 +30,7 @@ To change the version of Rails for the test app:
 ```bash
 export BUNDLE_GEMFILE=gemfiles/7.0.gemfile # change this to the version of Rails you need
 bundle update
-rails s -b 0.0.0.0 &
+bin/dev
 ```
 
 ### Automated Testing
@@ -49,6 +49,35 @@ To run the tests and the RuboCop checks, assuming you've set the `BUNDLE_GEMFILE
 rake
 ```
 
+## New Version of Rails
+
+I create a new app from scratch in a new directory.
+
+1. Install latest Rails: `gem install rails`.
+1. Create a new app: `cd test && rails new rails_app_8.0 --skip-git --javascript=esbuild --css bootstrap --skip-action-mailbox --skip-active-storage --skip-action-cable --skip-kamal --skip-solid`.
+1. `cd rails_app_8.0`.
+1. `rails db:prepare`.
+1. Update the `web` line of `Procfile.dov` to: `web: env RUBY_DEBUG_OPEN=true bin/rails server -b 0.0.0.0`.
+1. `bin/dev`.
+1. Follow the standard installation instructions from the [README](), but get the `devise-bootstrap-form` gem from the parent directory.
+    ```
+    gem "devise-bootstrap-form", path: "../.."
+    ```
+1. Follow the instructions in the [above section](#manual-and-exploratory-testing).
+1. Restart the server.
+
+### Internationalization
+
+**Very Important**
+
+To create a new instance of the test app for Spanish, you have to "customize" the translations provided by the `devise-i18n` gem. Generate them:
+
+```
+rails g devise:i18n:locale es
+```
+
+then change the instances of `user` in `config/locales/es.yml` to `person`.
+
 ## Gotchas
 
 To test that the views work for a model other than the default `User`, the test apps use `Person` as the Devise model. It's a bit frustrating to remember that you can't just cut and paste examples that assume the model is `User`.

Dangerfile

@@ -21,8 +21,8 @@ has_changelog_changes = git.modified_files.include?("CHANGELOG.md")
 # You've made changes to lib, but didn't write any tests?
 # ------------------------------------------------------------------------------
 if has_lib_changes && !has_test_changes
-  warn("There are code changes, but no corresponding tests. "\
-       "Please include tests if this PR introduces any modifications in "\
+  warn("There are code changes, but no corresponding tests. " \
+       "Please include tests if this PR introduces any modifications in " \
        "#{project_name}'s behavior.",
        sticky: false)
 end
@@ -32,14 +32,14 @@ end
 # ------------------------------------------------------------------------------
 if !has_changelog_changes && has_lib_changes
   markdown <<~MARKDOWN
-  Here's an example of a CHANGELOG.md entry (place it immediately under the `* Your contribution here!` line):
+    Here's an example of a CHANGELOG.md entry (place it immediately under the `* Your contribution here!` line):
 
-  ```markdown
-  * [##{pr_number}](#{pr_url}): #{github.pr_title} - [@#{github.pr_author}](https://github.com/#{github.pr_author}).
-  ```
+    ```markdown
+    * [##{pr_number}](#{pr_url}): #{github.pr_title} - [@#{github.pr_author}](https://github.com/#{github.pr_author}).
+    ```
   MARKDOWN
-  warn("Please update CHANGELOG.md with a description of your changes. "\
-       "If this PR is not a user-facing change (e.g. just refactoring), "\
+  warn("Please update CHANGELOG.md with a description of your changes. " \
+       "If this PR is not a user-facing change (e.g. just refactoring), " \
        "you can disregard this.", sticky: false)
 end
 

Gemfile

@@ -6,8 +6,7 @@ source "https://rubygems.org"
 gemspec
 
 group :development do
-  gem "chandler", ">= 0.7.0"
-  # gem "htmlbeautifier"
+  gem "rubocop-rails-omakase"
   gem "rubocop", require: false
   gem "rubocop-rake", require: false
 end

README.md

@@ -6,19 +6,18 @@ It also makes the Devise views simpler, because the code to define forms using `
 
 You can find usage information below, but the gist of it is you'll run `rails g devise:views:bootstrap_form` instead of the normal `rails g devise:views`.
 
-If you're just looking for Bootstrap markup on your Devise views, and don't want to use `bootstrap_form`, then you should look into the [`devise-bootstrapped`](https://github.com/king601/devise-bootstrapped) gem, or [`devise-bootstrap-views`](https://github.com/hisea/devise-bootstrap-views).
+If you're just looking for Bootstrap markup on your Devise views, and don't want to use `bootstrap_form`, then you should look into the [`devise-bootstrapped`](https://github.com/king601/devise-bootstrapped) gem, or the [`devise-bootstrap-views`](https://github.com/hisea/devise-bootstrap-views) gem.
 
 ## Installation
 
 Add these lines to your application's `Gemfile`:
 
 ```ruby
-gem 'bootstrap', '~> 5.0'
 gem "bootstrap_form", "~> 5.0"
-gem 'devise'
-# gem 'devise-i18n'
-# gem 'devise_invitable'
-gem 'devise-bootstrap-form'
+gem "devise"
+# gem "devise-i18n"
+# gem "devise_invitable"
+gem "devise-bootstrap-form"
 ```
 
 And then execute:
@@ -27,8 +26,8 @@ And then execute:
 bundle install
 ```
 
-There are additional installation instructions for [`bootstrap_form`](https://github.com/bootstrap-ruby/bootstrap_form#installation),  [`bootstrap`](https://github.com/twbs/bootstrap-rubygem#a-ruby-on-rails), [`devise`](https://github.com/plataformatec/devise) that you must complete before using `devise-bootstrap-form`, and
-[`devise-i18n`](https://github.com/tigrish/devise-i18n).
+There are additional installation instructions for [`bootstrap_form`](https://github.com/bootstrap-ruby/bootstrap_form#installation), [`devise`](https://github.com/plataformatec/devise) that you must complete before using `devise-bootstrap-form`, and
+[`devise-i18n`](https://github.com/devise-i18n/devise-i18n).
 
 Note that as of Devise 4.6.0, `devise_error_messages!` is deprecated in favour of the `_error_messages.html.erb` partial. `devise-bootstrap-form` versions 0.3.0 and higher generate views that use the `_error_messages.html.erb` partial. If you need to use `devise_error_messages!`, use this line in your `Gemfile`:
 

RELEASING.md

@@ -6,8 +6,7 @@ Follow these steps to release a new version of `devise-bootstrap-form` to `rubyg
 
 * You must have commit rights to the `devise-bootstrap-form` repository.
 * You must have push rights for the `devise-bootstrap-form` gem on `rubygems.org`.
-* You must be using Ruby >= 2.2.
-* Your GitHub credentials must be available to Chandler via `~/.netrc` or an environment variable, [as explained here](https://github.com/mattbrictson/chandler#2-configure-credentials).
+* You must be using Ruby >= 3.2.
 
 ## How to release
 

Rakefile

@@ -14,8 +14,3 @@ desc "Run RuboCop lint checks"
 RuboCop::RakeTask.new(:lint)
 
 task default: %i[test lint]
-
-require "chandler/tasks"
-
-# Add chandler as a prerequisite for `rake release`
-task "release:rubygem_push" => "chandler:push"