Skip to content

Commit 579d3fe

Browse files
committed
[add comments]
1 parent ac22f84 commit 579d3fe

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/actions/3-build-native/action.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ runs:
2222
build_dir: build
2323
host_dc: ../bootstrap-ldc/bin/ldmd2
2424
specify_install_dir: true
25-
# FIXME: sporadic compiler crashes on macOS arm64 when using mimalloc *and* mixing LLVM versions for Xcode clang/host LDC:
26-
# libc++abi: Pure virtual function called!
25+
# FIXME: mimalloc on macOS is tricky - when mixing newer LLVM from bootstrap LDC with older LLVM from Xcode clang,
26+
# causing *sporadic* compiler crashes: `libc++abi: Pure virtual function called!`
27+
# on x86_64, this is 'fixed' by using LTO - on arm64, this doesn't suffice
2728
cmake_flags: >-
2829
${{ (runner.os != 'Windows' && !(runner.os == 'macOS' && inputs.arch == 'arm64')) && '-DALTERNATIVE_MALLOC_O="$PWD/../build-mimalloc/CMakeFiles/mimalloc-obj.dir/src/static.c.o"' || '' }}
2930
${{ inputs.cmake_flags }}

.github/workflows/main.yml

+2
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ jobs:
8686
arch: arm64
8787
extra_cmake_flags: >-
8888
-DD_COMPILER_FLAGS="-O -flto=full -defaultlib=phobos2-ldc-lto,druntime-ldc-lto -L-exported_symbol '-L__*' -L-w"
89+
# FIXME: cannot enable LTO for C++ parts too, due to: `LLVM ERROR: Unsupported stack probing method` when linking ldc2
90+
# (apparently from bitcode files compiled with older Xcode clang)
8991
# -DEXTRA_CXXFLAGS=-flto=full
9092
with_pgo: true
9193

0 commit comments

Comments
 (0)