Skip to content

chore: rename Stream to Std.Stream #10645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TwoFX merged 1 commit into from
Oct 2, 2025
Merged

chore: rename Stream to Std.Stream #10645

TwoFX merged 1 commit into from
Oct 2, 2025

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Oct 1, 2025

This PR renames Stream to Std.Stream so that the name becomes available to mathlib after a deprecation cycle.

@TwoFX TwoFX requested a review from kim-em as a code owner October 1, 2025 18:49
@TwoFX TwoFX added the changelog-library Library label Oct 1, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-01 19:42:02)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10645
6ef19f5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10645
e432857
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 1, 2025 •
edited
Loading

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 2, 2025
@TwoFX TwoFX added this pull request to the merge queue Oct 2, 2025
Merged via the queue into leanprover:master with commit 5c707d9 Oct 2, 2025
35 checks passed
@fgdorais
Copy link
Contributor

fgdorais commented Oct 4, 2025

It would be great to give a heads up when such big changes happen. The Stream class is used a lot in Lean projects and that means a lot of annoying updates by a lot of people.

IMHO, that Mathlib needs the name to avoid Stream' is a very weak argument for this change.

arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@TwoFX @arthur-adjedj
chore: rename Stream to Std.Stream (leanprover#10645)
ea0fb20 
This PR renames `Stream` to `Std.Stream` so that the name becomes
available to mathlib after a deprecation cycle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TwoFX @leanprover-bot @leanprover-community-bot @fgdorais