refactor: lake: disambiguate packages by workspace index #11500
Merged
+347
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
changed the title
tydeu
force-pushed
the
lake/pkg-name-refactor
branch
from
847503f to
cf9c131
Compare
tydeu
force-pushed
the
lake/pkg-name-refactor
branch
from
cf9c131 to
8d734cb
Compare
Member
Author
|
!bench |
|
Benchmark results for 99c0d27 against dd28f00 are in! @tydeu |
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 4, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 4, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 4, 2025
leanprover-bot
added
the
breaks-manual
Collaborator
|
Reference manual CI status:
|
Collaborator
|
Mathlib CI status (docs):
|
tydeu
force-pushed
the
lake/pkg-name-refactor
branch
from
34c38e9 to
7f7915f
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 5, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 5, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 5, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 6, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 6, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 6, 2025
leanprover-community-bot
added
the
builds-mathlib
Member
Author
|
!bench |
|
Benchmark results for 3200264 against dd28f00 are in! @tydeu |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 9, 2025
github-actions
bot
added
the
mathlib4-nightly-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 9, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workspace-index to the name of the package used by build target. To clarify the distinction between the different uses of a package's name, this PR also deprecates
Package.namefor more use-specific variants (e.g.,Package.keyName,Package.prettyName,Package.origName).More to come. (WIP)