Skip to content

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Dec 9, 2025

This PR adds some information to Grove: a check that all string/slice-transforming functions are tracked properly (which finds dozens of missed cases), and some documentation of design designs around naming in the string library.

The PR also bumps the Grove version to the latest version which contains many new features and also processes the data a lot faster (40s to 2.5s for the test project).

@TwoFX TwoFX added changelog-no Do not include this PR in the release changelog grove The standard library changes in this PR should be analyzed using Grove. labels Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Grove for revision 1c47236.

Grove: no invalidated facts

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 9, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1d0d3915ca79d0875a757fc5061121ae9cd58543 --onto 62f2f9229356039356c0469a46d8ecd77be88e2a. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-09 08:26:06)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 1d0d3915ca79d0875a757fc5061121ae9cd58543 --onto 62f2f9229356039356c0469a46d8ecd77be88e2a. You can force reference manual CI using the force-manual-ci label. (2025-12-09 08:26:08)

@TwoFX TwoFX marked this pull request as ready for review December 9, 2025 15:43
@TwoFX TwoFX added this pull request to the merge queue Dec 9, 2025
Merged via the queue into leanprover:master with commit 9f99c51 Dec 9, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-no Do not include this PR in the release changelog grove The standard library changes in this PR should be analyzed using Grove. toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants