fix: goto-definition for binrel% operators #11558
Draft
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes goto-definition for binary relation operators.
**Problem:** Goto-def on `≥` went to the macro rule instead of `GE.ge`.
**Root cause:** In `elabBinRelCore`, the "uncomparable types" path (line 536)
called `elabAppArgs` directly without wrapping in `withTermInfoContext'`,
unlike `binop%` which goes through `toExprCore` that creates nested TermInfo.
**Fix:** Wrap the `elabAppArgs` call with `withTermInfoContext'` to match
`binop%` behavior.
**Note:** Initially tried adding `withInfo := true` to `resolveId? stx[1]`,
but that creates TermInfo with the unapplied type `{α : Type} → [LE α] → ...`
rather than the concrete instantiated type like `Nat → Nat → Prop`.
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes goto-definition for binary relation operators (
≥,≤,<,>,=,==).Problem: Goto-def on
≥navigated to themacro_rulesinstead ofGE.ge.Cause: The "uncomparable types" path in
elabBinRelCorecalledelabAppArgsdirectly withoutwithTermInfoContext', unlikebinop%which creates nested TermInfo viatoExprCore.Fix: Wrap with
withTermInfoContext'to matchbinop%behavior.Note: Initially tried
resolveId? stx[1] (withInfo := true), but that creates TermInfo with the unapplied type ({α : Type} → [LE α] → ...) rather than the instantiated type (Nat → Nat → Prop).🤖 Generated with Claude Code