-
Notifications
You must be signed in to change notification settings - Fork 713
feat: Switch from "math" to "mathlib" in the lake new <project> <template> syntax
#8487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
13453a5 to
2a7dc96
Compare
lake new <project> <template> syntaxlake new <project> <template> syntax
|
👍 from me, this is the only place where "math" is used to refer to mathlib, nothing in mathlib's own documentation does this. (Also somehow every time I read this command I am reminded of New Math...) |
|
Mathlib CI status (docs):
|
2a7dc96 to
893542f
Compare
|
I'm getting: Could someone help me add the appropriate |
|
You can set that label with a comment with just the name of the label as the comment text. |
|
changelog-lake |
|
Is there anything I should improve in the implementation, or does the code look good as it is? |
|
Sorry for not replying here sooner! I appreciate the effort, but I am not sold on this change. The Separately, naming the template |
Assuming that the For example, the current Personally, I would find it quite unintuitive if invoking To date, I don't recall seeing any documentation, or even informal discussion (e.g., on Zulip), suggesting that the |
|
@euprunin Your intuition makes sense. There has not really been a need to distinguish these notions before as they are currently synonymous. This PR is the first real reason to express this intent.
Yes, this line would be updated if more was added. This documentation states what is currently generated, it can change if things change. That is, it is not indicative of what the It may also be worth noting that there is some possibility in the future of there being another template that is more closely tied to Mathlib (e.g., with the same style options), which might better use the |
This PR switches the default template name from "math" to "mathlib" in the
lake new <project> <template>command, while continuing to support "math" for backward compatibility. This clarifies the intended use and avoids ambiguity in naming.