Skip to content

feat: add popcount to bv_decide #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
luisacicolini wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

feat: add popcount to bv_decide #11230

luisacicolini wants to merge 38 commits into from

Conversation

@luisacicolini
Copy link
Contributor

@luisacicolini luisacicolini commented Nov 18, 2025 •
edited
Loading

This PR adds the circuit to bitblast BitVec.cpop to bv_decide.

tobiasgrosser
tobiasgrosser reviewed Nov 18, 2025
View reviewed changes
@luisacicolini luisacicolini force-pushed the popcount-clean branch 2 times, most recently from 78299d5 to 4f6ac9f Compare November 26, 2025 10:21
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 8, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 8, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase cbf6fe5d1be2186da51492658cf1018f0762cc59 --onto 62f2f9229356039356c0469a46d8ecd77be88e2a. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-08 17:19:39)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 8, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase cbf6fe5d1be2186da51492658cf1018f0762cc59 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-08 17:19:41)

@luisacicolini
Copy link
Contributor Author

luisacicolini commented Dec 8, 2025

changelog-library

@github-actions github-actions bot added the changelog-library Library label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX will be requested when the pull request is marked ready for review hargoniX is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em will be requested when the pull request is marked ready for review kim-em is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura will be requested when the pull request is marked ready for review leodemoura is a code owner

1 more reviewer

@tobiasgrosser tobiasgrosser tobiasgrosser left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luisacicolini @leanprover-community-bot @leanprover-bot @tobiasgrosser