-
Notifications
You must be signed in to change notification settings - Fork 710
feat: add BEq to DHashMap/HashMap/HashSet and their extensional variants
#11266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wkrozowski
wants to merge
55
commits into
leanprover:master
Choose a base branch
from
wkrozowski:wojciech/hashmap_beq2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
BEq to DHashMap/HashMap/HashSet [Work in progress]BEq to DHashMap/HashMap/HashSet and their extensional variants.
BEq to DHashMap/HashMap/HashSet and their extensional variants.BEq to DHashMap/HashMap/HashSet and their extensional variants
Rob23oba
reviewed
Dec 2, 2025
TwoFX
reviewed
Dec 4, 2025
TwoFX
reviewed
Dec 4, 2025
Rob23oba
reviewed
Dec 4, 2025
Rob23oba
reviewed
Dec 5, 2025
wkrozowski
commented
Dec 8, 2025
wkrozowski
commented
Dec 8, 2025
wkrozowski
commented
Dec 8, 2025
wkrozowski
commented
Dec 8, 2025
wkrozowski
commented
Dec 8, 2025
wkrozowski
commented
Dec 8, 2025
| suffices tl.length ≤ (eraseKey hd.1 l₂).length by | ||
| rw [List.length_eraseKey, hc] at this | ||
| simp at this | ||
| simp |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-terminal simp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BEqinstance forDHashMap/HashMap/HashSetand their extensional variants and proves lemmas relating it to the equivalence of hashmaps/equality of extensional variants.