refactor: lake: CLI API overhaul #11435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
force-pushed
the
lake/cli-api-overhaul
branch
from
befe468 to
3a049c9
Compare
Member
Author
|
!bench |
|
Benchmark results for 3a049c9 against b0e6db3 are in! @tydeu Minor changes (3)
|
tydeu
force-pushed
the
lake/cli-api-overhaul
branch
from
3a049c9 to
7ca252e
Compare
Member
Author
|
!radar |
|
Benchmark results for 7ca252e against 5bd331e are in! @tydeu Minor changes (2)
|
tydeu
force-pushed
the
lake/cli-api-overhaul
branch
from
7ca252e to
d9d34eb
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 7, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 7, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 7, 2025
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 8, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 8, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Lake's CLI API and related code to make more use of the new String Slice API. It also generally expands the scope of the CLI API to cover argument parsing and some basic verification.
This is mostly a quality-of-life improvement for my use of the API in Lake and for adding additional CLI code in the future.