Skip to content

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 2, 2025

These complement the existing ExceptT.mk and OptionT.mk, and provide a symbol to key simp lemmas on, to prevent getting stuck on StateT.run (fun s => f s) s.

A future PR could insert these new mks into the implementation of many definitions, such that unfolding the definitions leaves appropriate casts behind; but this is invasive, and by itself having mk provides value.

These complement the existing `ExceptT.mk` and `OptionT.mk`, and provide a symbol to key `simp` lemmas on, to prevent getting stuck on `(StateT.run fun s => f s) s`.

A future PR could insert these new `mk`s into the implementation of many definitions, such that unfolding the definitions leaves appropriate casts behind; but this is invasive, and by itself having `mk` provides value.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 2, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 310abce62b40e4b876f797c4aef7e29d483feb42 --onto 5bd331e85d9d110a29fb3367dbb21854010ffcbd. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-02 07:55:11)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 310abce62b40e4b876f797c4aef7e29d483feb42 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-02 07:55:13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants