Skip to content

fix: ensure padding bytes for lean::mpz objects in olean files are zero #11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kha merged 1 commit into from
Dec 9, 2025
Merged

fix: ensure padding bytes for lean::mpz objects in olean files are zero #11485

Kha merged 1 commit into from
Dec 9, 2025
+7 −1

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 3, 2025 •
edited
Loading

This PR ensures that Nats in .olean files use a deterministic serialization in the case where LEAN_USE_GMP is not set.

This is a simplified version of #2908.

@eric-wieser
Copy link
Contributor Author

eric-wieser commented Dec 3, 2025

changelog-language

@github-actions github-actions bot added changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Dec 3, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 3, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-03 02:06:15)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11485
5ef4573
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11485
085a76b
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 3, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 3, 2025 •
edited
Loading

Mathlib CI status (docs):

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 3, 2025
@Kha Kha enabled auto-merge December 3, 2025 13:27
@Kha Kha added this pull request to the merge queue Dec 3, 2025
@Kha Kha removed this pull request from the merge queue due to a manual request Dec 3, 2025
@Kha Kha enabled auto-merge December 3, 2025 13:29
@eric-wieser
Copy link
Contributor Author

eric-wieser commented Dec 4, 2025

@Kha, looks like the tests are flaky, presumably unrelated to this change.

@Kha Kha added this pull request to the merge queue Dec 9, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 9, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11485
7690ae6
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Dec 9, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 9, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11485
09021ae
Merged via the queue into leanprover:master with commit 6e711bf Dec 9, 2025
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digama0 digama0 digama0 approved these changes

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eric-wieser @leanprover-bot @leanprover-community-bot @digama0 @Kha