feat: exact? finds eliminator-style theorems like iteInduction #11489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables `exact?` to find theorems with fvar-headed conclusions like `iteInduction : motive (ite c t e)` when the goal has a matching structure like `p (if h then x else y)`. Previously, such theorems were indexed under `.star` and dropped because they matched too many goals. Now we add secondary entries indexed by the first concrete argument's structure. Changes: - LibrarySearch.lean: Add `getFirstArgEntry` to extract secondary index entries from fvar-headed conclusions - LazyDiscrTree.lean: Modify `getMatchCore` to search by first argument's key when goal has fvar head 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
kim-em
force-pushed
the
librarySearch-eliminators
branch
from
b221395 to
d0935fc
Compare
kim-em
changed the title
kim-em
force-pushed
the
librarySearch-eliminators
branch
from
2a0af34 to
9249ecc
Compare
kim-em
changed the title
exact? finds theorems of the form f (const x y) z, with variable head
kim-em
changed the title
exact? finds theorems of the form f (const x y) z, with variable head
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Collaborator
Author
|
I am skeptical about this PR, I think just going all the way to #11494 is a better idea. Keeping it around for now in case I run into obstacles there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
exact?to find theorems with fvar-headed conclusions likeiteInduction : motive (ite c t e)when the goal has a matching structure likep (if h then x else y).Previously, such theorems were indexed under
.starbut their argument structure was not preserved, so they couldn't be matched effectively. Now when indexing fvar-headed terms, we also push their arguments to the discrimination tree, enabling matching by argument structure.Changes:
LazyDiscrTree.lean: InpushArgs, when encountering an fvar head with arguments, push those arguments to the todo list (previously they were dropped)LazyDiscrTree.lean: IngetMatchCore, when the goal has an fvar head, follow the.staredge with the fvar's arguments to find matching theorems🤖 Prepared with Claude Code