Skip to content

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 3, 2025

This PR prevents try swallowing heartbeat errors from nested simp calls, and more generally ensures the isRuntime flag is propagated by throwNestedTacticEx. This prevents the behavior of proofs (especially those using aesop) being affected by the current recursion depth or heartbeat limit.

This breaks a single caller in Mathlib where simp uses a lemma of the form x = f (g x) and stack overflows, which can be fixed by generalizing over g x.

Closes #7811.

@eric-wieser
Copy link
Contributor Author

changelog-language

@github-actions github-actions bot added the changelog-language Language features and metaprograms label Dec 3, 2025
@eric-wieser eric-wieser force-pushed the throwNestedTacticEx-tags branch from 8897bd8 to 008ca15 Compare December 3, 2025 03:09
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 3, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 3, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-03 04:06:10)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase bf51e1dcfa3322f639cb17e283a9b8caa1c16209 --onto 62f2f9229356039356c0469a46d8ecd77be88e2a. You can force reference manual CI using the force-manual-ci label. (2025-12-09 11:26:56)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 3, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 3, 2025
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 3, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 3, 2025

Mathlib CI status (docs):

  • 💥 Mathlib branch lean-pr-testing-11490 build failed against this PR. (2025-12-03 04:59:04) View Log
  • ✅ Mathlib branch lean-pr-testing-11490 has successfully built against this PR. (2025-12-04 00:51:47) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase bf51e1dcfa3322f639cb17e283a9b8caa1c16209 --onto 1d0d3915ca79d0875a757fc5061121ae9cd58543. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-09 11:26:54)

@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Dec 4, 2025
@Kha
Copy link
Member

Kha commented Dec 9, 2025

!bench

@leanprover-radar

This comment was marked as outdated.

@Kha
Copy link
Member

Kha commented Dec 9, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Dec 9, 2025

Benchmark results for 89cebd1 against bf51e1d are in! @Kha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

throwNestedTacticEx silences runtime errors

5 participants