feat: lint coercions that are deprecated or banned in core #11511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix test and simp 'copy' to 'toArray' write linter add backticks make the linter more defensive to avoid panics make sure stage0 is updated after merging revert the changes in src/Lean why doesn't this work? Revert "revert the changes in src/Lean" This reverts commit 75c7082. revert the changes in src/Lean
…fo to override the term info
datokrat
force-pushed
the
paul/slices/subarraycopy
branch
from
fd79930 to
1e5d986
Compare
Contributor
Author
|
!radar |
|
Benchmark results for 9cb732c against 0173444 are in! @datokrat Minor changes (5)
|
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 4, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 4, 2025
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 5, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 5, 2025
mhuisi
reviewed
Dec 5, 2025
| return (← getOptions).get linter.deprecatedCoercions.name true | ||
|
|
||
| /-- A list of coercion names that must not be used in core. -/ | ||
| def coercionsBannedInCore : List Name := [``optionCoe, ``instCoeSubarrayArray] |
Contributor
There was a problem hiding this comment.
Array? Not that it matters much :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a linter that warns when a deprecated coercion is applied. It also warns when the
Optioncoercion or theSubarray-to-Arraycoercion is used inInitorStd. The linter is currently limited toCoeinstances;CoeFuninstances etc. are not considered.The linter works by collecting the
Coeinstance declaration names that are being expanded inexpandCoe?and storing them in the info tree. The linter itself then analyzes the info tree and checks for banned or deprecated coercions.