feat: use approximate universe inverse when sorry in inductive type
#11524
+137
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the universe level constraint algorithms for the inductive type elaborator to use an approximation for constructor fields that contain sorry. For example, the following used to fail with an 'accidental higher universe' error due to the fact that the
sorry's universe level constraint is of the formu ≤ ?r + 1, which is often a mistake.The following example also used to fail, since the constraint was
?u ≤ 1, which does not have a unique solution. It now takes the least solution if there is asorry.This PR also avoids a spurious 'accidental higher universe' error in the following case, which has the constraints
u ≤ ?r + 1andu ≤ ?r. While the second implies the first, it would still warn about the first.