Skip to content

Conversation

@maxwell3025
Copy link

@maxwell3025 maxwell3025 commented Dec 7, 2025

This PR corrects the JSON Schema at src/lake/schemas/lakefile-toml-schema.json to allow the table variant of the require.git field in lakefile.toml as specified in the reference.

Closes #11535

@maxwell3025 maxwell3025 changed the title Add Table Variant for require.git Field in lakefile.toml Schema fix: add table variant for require.git field in lakefile.toml schema Dec 7, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 7, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 7, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2ca3bc28590c5c33f755d3bd18252f25ea266266 --onto 455fd0b4488e2adc85f825a52e2ee7d944a5740a. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-07 01:44:22)
  • ✅ Mathlib branch lean-pr-testing-11536 has successfully built against this PR. (2025-12-07 16:38:29) View Log
  • ✅ Mathlib branch lean-pr-testing-11536 has successfully built against this PR. (2025-12-07 17:39:07) View Log
  • ✅ Mathlib branch lean-pr-testing-11536 has successfully built against this PR. (2025-12-08 22:41:13) View Log

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 7, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 2ca3bc28590c5c33f755d3bd18252f25ea266266 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-07 01:44:23)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-07 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-07 15:34:31)

@maxwell3025 maxwell3025 marked this pull request as ready for review December 7, 2025 03:50
@maxwell3025 maxwell3025 requested a review from tydeu as a code owner December 7, 2025 03:50
@maxwell3025
Copy link
Author

maxwell3025 commented Dec 7, 2025

I don't have the permissions necessary to add labels, but this should have the label changelog-server

@maxwell3025 maxwell3025 marked this pull request as draft December 7, 2025 03:58
@maxwell3025 maxwell3025 marked this pull request as ready for review December 7, 2025 03:58
@@ -0,0 +1,16 @@
#!/usr/bin/env bash
TAPLO_URL=https://github.com/tamasfe/taplo/releases/latest/download/taplo-linux-x86_64.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we really want the core test suite to depend on Taplo, which is apparently currently not being actively maintained anymore.
I'd be happy to have these tests in leanprover/vscode-lean4, though, which is after all also the actual component that depends on Taplo :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they also mentioned this on Zulip. Should lakefile-toml-schema.json be moved to vscode-lean4 instead? It seems like it would be awkward to have the tests and the component being tested in different repos.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should lakefile-toml-schema.json be moved to vscode-lean4 instead?

I'd still keep it here.

It seems like it would be awkward to have the tests and the component being tested in different repos.

I maintain both, so I suspect that this will not be much of a problem in practice. We can revisit this later if it does turn out to be a problem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a draft pull request at vscode-lean4.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 7, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 7, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 7, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 7, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 7, 2025
@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Dec 8, 2025
@maxwell3025 maxwell3025 requested a review from mhuisi December 8, 2025 20:39
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 8, 2025
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Dec 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-server Language server, widgets, and IDE extensions mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Types in TOML Schema for lakefile.toml

4 participants