fix: make register_try?_tactic auxiliary definitions internal
#11547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
changed the title
register_try?_tactic auxiliary definitions internal
The auxiliary definitions created by `register_try?_tactic` are internal implementation details that should not be visible to user-facing linters. This change marks them as internal by using `Name.mkSimpleInternal` instead of `Name.mkSimple`, which automatically exempts them from linting via the existing `isAutoDecl` check in Batteries. Fixes linter errors in downstream projects (e.g., Mathlib) when using `register_try?_tactic`. 🤖 Generated with Claude Code
kim-em
force-pushed
the
fix-register-try-tactic-internal-names
branch
from
625b997 to
62ded6e
Compare
Collaborator
Author
|
Fixed the build error - doesn't exist. The correct approach is to prefix the name with |
algebraic-dev
pushed a commit
that referenced
this pull request
Dec 8, 2025
This PR ensures the auxiliary definitions created by `register_try?_tactic` are internal implementation details that should not be visible to user-facing linters. 🤖 Generated with Claude Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the auxiliary definitions created by
register_try?_tacticare internal implementation details that should not be visible to user-facing linters.🤖 Generated with Claude Code