feat: let synth order checker detect generalized projections #7310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies the instance synth order checker to detect projections-like instances, rather having special support only for constructor field projections. An instance is projection-like if the first instance implicit argument has a type that's a constant applied to all the preceding arguments in order — these arguments are assumed to be the parameters of the type. In the future the `class` command will make all its generated parent projections use implicits for all parameters, making the generated projections all consistent.
kmill
added
awaiting-review
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 3, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 3, 2025
leanprover-community-bot
added
the
breaks-mathlib
Collaborator
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the instance synth order checker to detect projections-like instances, rather having special support only for constructor field projections. An instance is projection-like if the first instance implicit argument has a type that's a constant applied to all the preceding arguments in order — these arguments are assumed to be the parameters of the type.
In the future the
classcommand will make all its generated parent projections use implicits for all parameters, making the generated projections all consistent.