refactor: configurable source for highlighting - #881
Merged
Conversation
Collaborator
|
This seems fine - thanks for the whitespace hint! It would be nice if the PR description included the motivation for the change, because that will be the commit message in the future, and this could be mysterious without a bit of context. Otherwise, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows doc highlighting information to be be provided from a different source, instead of just a hardcoded
-verso-docs.jsonresource file. It also incidentally turns the get-highlighting-json operation from a chained promise to an await-ed one.The reason for this change is to eventually allow the lean4web app to generate a single-file page that only refers to external static assets — the main per-document assets for a single-page HTML development are index.html, the highlighting information file, and search data (which can be omitted from a single-page HTML development).
(Hint: the diff is quite small if you preview with whitespace changes off.)