Replies: 5 comments 14 replies
-
Beta Was this translation helpful? Give feedback.
-
|
Yes, this is a major change in the current theming infrastructure. The good thing is that we never need to support more than one version of Bootstrap. However, we do need to ensure that the infrastructure remains backwards compatible to the existing DB tags that you've identified (in other words, when we migrate a production site to the new codebase, the tags should still work). I think the general path forward would like something like this:
We shouldn't do all of this at once. In fact, each of the above steps would probably be one (or more) separate pull request(s). |
Beta Was this translation helpful? Give feedback.
-
|
@willgearty @Oval17, I’m also interested in working on this migration. Since it’s a multi-step process (BS2 -> BS3 -> BS4 -> BS5), it makes sense to split the work for better efficiency. @Oval17, do you want to continue focusing on the DB tag mapping and variable injection logic you’ve already started, while I handle the template/class updates for the Bootstrap 2 to 3 transition? Once we agree on the split, we can coordinate the first PR to ensure we maintain the backwards compatibility @willgearty mentioned. |
Beta Was this translation helpful? Give feedback.
-
|
@Oval17 @Arnav1709 For now, you can go through the codebase and plan your approach accordingly. Working on tasks before the program starts isn’t considered a good practice. Also, we currently have a limited number of team members for reviews, and at the moment, most of the review work is being handled by @willgearty. Please allow him sufficient time to review everything. Meanwhile, focus on preparation and understanding the project well. |
Beta Was this translation helpful? Give feedback.
-
|
Hello, i did not find any relevant slack or discord channel for learning unlimited! Do we have to discuss about the issues/approach here only ? |
Beta Was this translation helpful? Give feedback.



Uh oh!
There was an error while loading. Please reload this page.
-
What All I have done till now :
1 -> (Very Imp) : Did local setup and tested current flow of our app and Different Features.
2 -> Understood the flow of our Bootstrap 2 Site
cc : @willgearty @kkbrum
We can discuss regarding this feature upgrade here in detial.
Beta Was this translation helpful? Give feedback.
All reactions