KTextbox: Unnecessary dom node and some styles cause unexpected space

[AlexVelezLl]

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Observed behavior

KTextbox always renders this ui-textbox-feedback even if no feedback (e.g., error messages) are being shown. This causes some horizontal layouts where KTextbox is next to other inputs; the different inputs are stretched to match KTextbox's height.

In vertical layouts, this node also causes a discrepancy in the gap size between inputs.

Expected behavior

In general, it seems we need to find a better, standard way to align for these horizontal and vertical layouts when we have several inputs for different fields. At first, when no feedback is needed, we can just hide this node, but if we have invalid text set for the KTextbox, we will still have the problem of the other inputs being stretched.

[MisRob]

I was just going to report this because of another use-case. In the collections table, unnecessary presence of .ui-textbox-feedback, ui-textbox-feedback-text in DOM + .mh's min-height + .ui-textbox margin-bottom causes the following problem with extra space below the token readonly input:

Unfortunatelly, this is far beyond what we can resolve via appearanceOverride or similar. So here I had to

::v-deep .mh {
  min-height: unset !important;
}

::v-deep .ui-textbox {
  margin-bottom: 0 !important;
}

::v-deep .ui-textbox-feedback,
::v-deep .ui-textbox-feedback-text {
  height: 0 !important;
  padding: 0 !important;
  overflow: hidden !important;
}

to achieve:

It took considerable amount of time to figure out how to be able to use KTextbox in this place.

[MisRob]

In the first place, KTextbox shouldn't occupy extra space by default. Second, there needs to be a simple way to configure its minimum height (or padding, margin, etc.:

<KTextbox :style={ minHeight: ... }

which can then be used to optimize alignment in grids, e.g. in use-cases that @AlexVelezLl mentions.

However, this won't be possible until we get rid of Keen-related structure where KTextbox is a wrapper around UiTextbox. So I think it'd be meaningful to resolve this in scope of Keen tech debt removal.

[MisRob]

@AlexVelezLl I updated the issue title to also reflect additional findings I posted above