make ready for customfieldsemester

Author: bluetom

classes/processor.php

@@ -365,7 +365,7 @@ public function get_count_of_courses_to_trigger_for_workflow($workflow) {
                 $obj->excluded = 0;
                 // Only use triggers with true sql to display the real amounts for the others (instead of always 0).
                 $obj->sql = trigger_manager::get_trigger_sqlresult($trigger);
-                $obj->response = $lib->check_course();
+                $obj->response = $lib->check_course(null, null);
                 if ($obj->sql != "false") {
                     if ($obj->response == trigger_response::exclude()) {
                         // Get courses excluded amount.

lang/de/tool_lifecycle.php

@@ -99,6 +99,7 @@
 $string['create_step'] = 'Step erstellen';
 $string['create_trigger'] = 'Trigger erstellen';
 $string['create_workflow_from_existing'] = 'Kopie von bestehendem Workflow erstellen';
+$string['customfieldsemesterdescription'] = 'Löst Kurse gemäß dem benutzerdefinierten Kursfeld \'semester\' aus.';
 $string['date'] = 'Fällligkeitsdatum';
 $string['deactivated'] = 'Deaktiviert';
 $string['deactivated_workflows_header'] = 'Inaktive';

lang/en/tool_lifecycle.php

@@ -99,6 +99,7 @@
 $string['create_step'] = 'Create step';
 $string['create_trigger'] = 'Create trigger';
 $string['create_workflow_from_existing'] = 'Copy new workflow from existing';
+$string['customfieldsemesterdescription'] = 'Trigger courses by the course custom field \'semester\'';
 $string['date'] = 'Due date';
 $string['deactivated'] = 'Deactivated';
 $string['deactivated_workflows_header'] = 'Deactivated';

settings.php

@@ -79,9 +79,15 @@
             if ($trigger == 'sitecourse' || $trigger == 'delayedcourses') {
                 $uninstall = html_writer::span(' Depracated. Will be removed with version 5.0.', 'text-danger');
             }
-            $settings->add(new admin_setting_description('lifecycletriggersetting_'.$trigger,
-                get_string('pluginname', 'lifecycletrigger_' . $trigger),
-                get_string('plugindescription', 'lifecycletrigger_' . $trigger).$uninstall));
+            if ($trigger == 'customfieldsemester') {
+                $settings->add(new admin_setting_description('lifecycletriggersetting_'.$trigger,
+                    get_string('pluginname', 'lifecycletrigger_' . $trigger),
+                    get_string('customfieldsemesterdescription', 'tool_lifecycle')));
+            } else {
+                $settings->add(new admin_setting_description('lifecycletriggersetting_'.$trigger,
+                    get_string('pluginname', 'lifecycletrigger_' . $trigger),
+                    get_string('plugindescription', 'lifecycletrigger_' . $trigger).$uninstall));
+            }
         }
     } else {
         $settings->add(new admin_setting_heading('adminsettings_notriggers',

trigger/byrole/lib.php

@@ -60,7 +60,7 @@ public function get_course_recordset_where($triggerid) {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
             return trigger_response::trigger();
     }
 

trigger/categories/lib.php

@@ -47,7 +47,7 @@ class categories extends base_automatic {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
         return trigger_response::trigger();
     }
 

trigger/delayedcourses/lib.php

@@ -44,7 +44,7 @@ class delayedcourses extends base_automatic {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
         return trigger_response::exclude();
     }
 

trigger/lib.php

@@ -143,7 +143,7 @@ abstract class base_automatic extends base {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    abstract public function check_course($course = null, $triggerid = null);
+    abstract public function check_course($course, $triggerid);
 
     /**
      * Defines if the trigger subplugin is started manually or automatically.

trigger/semindependent/lib.php

@@ -45,7 +45,7 @@ class semindependent extends base_automatic {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
         return trigger_response::trigger();
     }
 

trigger/sitecourse/lib.php

@@ -42,7 +42,7 @@ class sitecourse extends base_automatic {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
         return trigger_response::trigger();
     }
 

trigger/specificdate/lib.php

@@ -47,7 +47,7 @@ class specificdate extends base_automatic {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
         return trigger_response::triggertime();
     }
 

trigger/startdatedelay/lib.php

@@ -45,7 +45,7 @@ class startdatedelay extends base_automatic {
      * @param int $triggerid DEPRECATED
      * @return trigger_response
      */
-    public function check_course($course = null, $triggerid = null) {
+    public function check_course($course, $triggerid) {
         return trigger_response::trigger();
     }