[FIX] website_*: correct 3 data bugs found in re-review

- website_event: remap only 'location' — track/track_proposal still exist in
  19 (website_event_track selection_add); the broad remap corrupted them.
- website_slides: raw DELETE of the access-request activity type hits
  mail_activity's RESTRICT FK on live DBs — use the safe-delete helper; and
  restore + load the 4 ir.rule link-visibility domains the noupdate trim had
  dropped (link-shared courses were invisible to public/portal users).
- website_crm_partner_assign: delete by post-apriori-merge xml_ids — the
  website_membership-prefixed ones no longer exist when the script runs.

Author: dnplkndll

openupgrade_scripts/scripts/website_crm_partner_assign/19.0.1.2/pre-migration.py

@@ -1,11 +1,12 @@
 from openupgradelib import openupgrade
 
-# Obsolete website_membership noupdate record rules removed in 19.0; noupdate
+# Obsolete website_membership noupdate record rules removed in 19.0 (their
+# ir_model_data already moved here by the apriori merge in base); noupdate
 # records aren't swept by the standard module update, so delete them by xml_id
 # (record + ir_model_data) to drop the stale public membership access.
 _obsolete_rule_xmlids = [
-    "website_membership.membership_membership_line_public",
-    "website_membership.membership_product_product_public",
+    "website_crm_partner_assign.membership_membership_line_public",
+    "website_crm_partner_assign.membership_product_product_public",
 ]
 
 

openupgrade_scripts/scripts/website_event/19.0.1.4/post-migration.py

@@ -3,8 +3,9 @@
 
 @openupgrade.migrate()
 def migrate(env, version):
-    # Map menu_type values removed in 19.0 to the new "other" key.
+    # Map the menu_type value removed in 19.0 to the new "other" key. track /
+    # track_proposal still exist (selection_add in website_event_track).
     env["website.event.menu"].search(
-        [("menu_type", "in", ("location", "track", "track_proposal"))]
+        [("menu_type", "=", "location")]
     ).menu_type = "other"
     openupgrade.load_data(env, "website_event", "19.0.1.4/noupdate_changes.xml")

openupgrade_scripts/scripts/website_slides/19.0.2.7/noupdate_changes.xml

@@ -1,3 +1,53 @@
-<?xml version='1.0' encoding='utf-8'?>
+<?xml version='1.0' encoding='UTF-8'?>
 <odoo>
+  <record id="rule_slide_channel_visibility_public_user" model="ir.rule">
+    <field name="domain_force">[('website_published', '=', True), ('visibility', 'in', ['public', 'link'])]</field>
+    <field name="name">Channel: public: restricted to public/link-based and published</field>
+  </record>
+  <record id="rule_slide_channel_visibility_signed_in_user" model="ir.rule">
+    <field name="domain_force">[
+                '&amp;',
+                    ('website_published', '=', True),
+                    '|',
+                        ('visibility', 'in', ('public', 'connected', 'link')),
+                        '|',
+                            ('is_member_invited', '=', True),
+                            ('is_member', '=', True),
+                ]
+            </field>
+    <field name="name">Channel: portal/user: restricted to published, public or (invited) attendee or link-based, connected user</field>
+  </record>
+  <record id="rule_slide_slide_public_user" model="ir.rule">
+    <field name="domain_force">[
+                    ('channel_id.website_published', '=', True),
+                    ('website_published', '=', True),
+                    ('channel_id.visibility', 'in', ['public', 'link']),
+                    '|',
+                        ('is_category','=', True),
+                        ('is_preview', '=', True),
+                ]
+            </field>
+    <field name="name">Slide: public: restricted to published or public/link-based channel &amp; (category or previewable)</field>
+  </record>
+  <record id="rule_slide_slide_signed_in_user" model="ir.rule">
+    <field name="domain_force">[
+                '&amp;',
+                    '|',
+                        ('user_id', '=', user.id),
+                        '&amp;',
+                            ('website_published', '=', True),
+                            ('channel_id.website_published', '=', True),
+                    '|',
+                        '&amp;',
+                            '|',
+                                ('channel_id.visibility', 'in', ('public', 'connected',  'link')),
+                                ('channel_id.is_member_invited', '=', True),
+                            '|',
+                                ('is_category', '=', True),
+                                ('is_preview', '=', True),
+                        ('channel_id.is_member', '=', True),
+                ]
+            </field>
+    <field name="name">Slide: portal/user: restricted to published and connected user, (invited) attendee or link-based, if course visible to attendees only</field>
+  </record>
 </odoo>

openupgrade_scripts/scripts/website_slides/19.0.2.7/post-migration.py

@@ -0,0 +1,6 @@
+from openupgradelib import openupgrade
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    openupgrade.load_data(env, "website_slides", "19.0.2.7/noupdate_changes.xml")

openupgrade_scripts/scripts/website_slides/19.0.2.7/pre-migration.py

@@ -1,16 +1,11 @@
 from openupgradelib import openupgrade
 
+# Removed in 19.0; raw SQL would hit mail_activity's RESTRICT FK on DBs with
+# open access-request activities — the safe helper deactivates instead.
+
 
 @openupgrade.migrate()
 def migrate(env, version):
-    openupgrade.logged_query(
-        env.cr,
-        """
-        DELETE FROM mail_activity_type WHERE id IN (
-            SELECT imd.res_id FROM ir_model_data imd
-            WHERE imd.model = 'mail.activity.type'
-              AND imd.module = 'website_slides'
-              AND imd.name = 'mail_activity_data_access_request'
-        )
-        """,
+    openupgrade.delete_records_safely_by_xml_id(
+        env, ["website_slides.mail_activity_data_access_request"]
     )