[19.0][FIX] dms: address review findings on the 18.0→19.0 migration

Three regressions identified during code review of the migration commit
([19.0][MIG] dms: Migration to 19.0). All restore behaviour that was
present in the 18.0 baseline and silently dropped during the port.

1. **File kanban view loses its Upload/Scan buttons.** The 18.0
   `dms.KanbanButtons` template was deleted and
   `buttonTemplate: "dms.KanbanButtons"` was removed from
   `FileKanbanView`. A replacement template
   (`dms.FileKanbanView.Buttons`) was added in
   `file_kanban_controller.xml` but never wired into the view config,
   and the template's `t-ref` + `t-on-change` names did not match the
   `createFileUploadExtension()` API
   (`fileInput` / `onChangeFileInput` / `uploadDocument`). Fix:
   - Realign `dms.FileKanbanView.Buttons` to the extension's actual
     ref/handler names, and restore the responsive mobile-Scan +
     desktop-Upload pair.
   - Add `buttonTemplate: "dms.FileKanbanView.Buttons"` to
     `FileKanbanView` so the kanban toolbar actually receives the
     buttons.

2. **`filter_domain` silently dropped from category + tag search.**
   The 18.0 views explicitly set:
   - `dms.category` → `['|', ('name', 'ilike', self), ('parent_id', 'child_of', raw_value)]`
     (searching a parent category surfaces descendants — important UX
     for hierarchical categories like `Internal / Human Resource`).
   - `dms.tag` → `[('name', 'ilike', self)]` (case-insensitive
     contains-match; locks in semantics regardless of Odoo's evolving
     default field-search behaviour).
   The migration replaced both with bare `<field name="name" />`,
   changing search semantics. Restored both explicitly with a comment
   noting why.

3. **List-renderer xpath `.` is correct but unobvious.** Odoo 19's
   `web.ListView.Buttons` is a flat list of `<button>` siblings — the
   18.0 `o_list_buttons` wrapper div is gone, so the prior class-scoped
   xpath has no anchor. Bare `.` (the implicit root) is the right
   answer in 19, but it reads as fragile. Added a comment block above
   the three `<xpath>` blocks explaining the Odoo-19-side change and
   why three separate one-node patches are preferable to a single
   multi-node patch (sibling-addon merge friendliness).

Author: dnplkndll

dms/static/src/js/views/file_kanban_controller.xml

@@ -1,25 +1,56 @@
 <?xml version="1.0" encoding="UTF-8" ?>
+<!--
+    Copyright 2020 Creu Blanca
+    Copyright 2017-2019 MuK IT GmbH
+    Copyright 2024 Subteno - Timothée Vannier (https://www.subteno.com).
+    License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
+-->
 <templates>
+    <!--
+        Restores the mobile-first Scan + desktop Upload affordance that lived
+        in the 18.0 `dms.KanbanButtons` template. The 19.0 migration deleted
+        the prior wire-up; this template is registered as
+        `FileKanbanView.buttonTemplate` so the toolbar still ships an upload
+        path even when drag-and-drop is unavailable (touch devices).
+
+        Refs/handlers come from `createFileUploadExtension()` patched onto
+        `KanbanController.prototype` in `file_kanban_view.esm.js`:
+
+          - `fileInput`        — hidden <input type="file">
+          - `uploadDocument()` — programmatically clicks the input
+          - `onChangeFileInput()` — uploads the picked files
+    -->
     <t
         t-name="dms.FileKanbanView.Buttons"
         t-inherit="web.KanbanView.Buttons"
         t-inherit-mode="primary"
     >
-        <div role="toolbar" position="inside">
-            <input
-                type="file"
-                multiple="true"
-                t-ref="uploadFileInput"
-                class="o_input_file o_hidden"
-                t-on-change.stop="onFileInputChange"
-            />
-            <button
-                type="button"
-                t-attf-class="btn btn-primary o_file_kanban_upload"
-                t-on-click.stop.prevent="() => this.uploadFileInputRef.el.click()"
-            >
-                Upload
-            </button>
-        </div>
+        <xpath expr="//div" position="inside">
+            <t t-if="props.archInfo.activeActions.create">
+                <button
+                    type="button"
+                    class="d-inline d-md-none btn btn-primary mx-1"
+                    t-on-click.prevent="uploadDocument"
+                >
+                    Scan
+                </button>
+                <input
+                    type="file"
+                    name="ufile"
+                    class="d-none"
+                    t-ref="fileInput"
+                    multiple="1"
+                    accept="*"
+                    t-on-change="onChangeFileInput"
+                />
+                <button
+                    type="button"
+                    class="d-none d-md-inline btn btn-primary mx-1"
+                    t-on-click.prevent="uploadDocument"
+                >
+                    Upload
+                </button>
+            </t>
+        </xpath>
     </t>
 </templates>

dms/static/src/js/views/file_kanban_view.esm.js

@@ -21,6 +21,7 @@ FileKanbanRenderer.template = "dms.KanbanRenderer";
 
 export const FileKanbanView = {
     ...kanbanView,
+    buttonTemplate: "dms.FileKanbanView.Buttons",
     Renderer: FileKanbanRenderer,
 };
 

dms/static/src/js/views/file_list_renderer.xml

@@ -1,4 +1,10 @@
 <?xml version="1.0" encoding="UTF-8" ?>
+<!--
+    Copyright 2020 Creu Blanca
+    Copyright 2017-2019 MuK IT GmbH
+    Copyright 2024 Subteno - Timothée Vannier (https://www.subteno.com).
+    License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
+-->
 <templates xml:space="preserve">
     <t t-name="dms.ListRenderer" t-inherit="web.ListRenderer" t-inherit-mode="primary">
         <xpath expr="//div[hasclass('o_list_renderer')]" position="before">
@@ -8,6 +14,16 @@
         </xpath>
     </t>
 
+    <!--
+        Append our Upload/Scan/file-input siblings into Odoo 19's
+        `web.ListView.Buttons` template. The 18.0 xpath targeted
+        `//div[hasclass('o_list_buttons')]`; that wrapper div is gone in
+        Odoo 19 — `web.ListView.Buttons` is now a flat list of `<button>`
+        siblings, so `.` (the implicit root) is the only valid anchor.
+        Three separate `<xpath>` blocks are intentional: each adds one
+        sibling node and lets sibling addons re-order without merge
+        conflicts on a single multi-node patch.
+    -->
     <t
         t-name="dms.ListButtons"
         t-inherit="web.ListView.Buttons"

dms/views/dms_category.xml

@@ -12,7 +12,17 @@
         <field name="model">dms.category</field>
         <field name="arch" type="xml">
             <search string="Categories">
-                <field name="name" />
+                <!--
+                    Match either the category name itself OR any descendant
+                    category (so typing "Invoices" surfaces sub-categories
+                    nested under it). The 18.0 view set this; the 19.0
+                    migration dropped it. Restored here so search semantics
+                    stay backwards-compatible.
+                -->
+                <field
+                    name="name"
+                    filter_domain="['|', ('name', 'ilike', self), ('parent_id', 'child_of', raw_value)]"
+                />
                 <filter
                     string="All"
                     name="all"

dms/views/dms_tag.xml

@@ -12,7 +12,13 @@
         <field name="model">dms.tag</field>
         <field name="arch" type="xml">
             <search string="Categories">
-                <field name="name" />
+                <!--
+                    Explicit `filter_domain` so the searchbar's default ANY
+                    autocompletion stays case-insensitive `ilike` (Odoo 19's
+                    default field-search behaviour changed; the 18.0 view
+                    locked this in). Restored from the 18.0 baseline.
+                -->
+                <field name="name" filter_domain="[('name', 'ilike', self)]" />
                 <filter
                     string="All"
                     name="all"