feat(farm_fence): fence lines + condition tracking + length compute (#6)

* feat(farm_base): add farm.mixin AbstractModel for color/notes/mail.thread

Eliminates ~12 lines × 8+ farm models. All SMB-tier models and existing farm
modules can _inherit = ["farm.mixin"] to pick up the shared bundle in one line.

* feat(farm_crop): catalog of farm crops with 18 seeded entries

farm.crop is the canonical crop identity referenced by farm.field, farm.planting,
and farm.harvest. Ships with 18 common US small-farm crops under noupdate=1 so
farmers can edit freely.

Fields:
- name, latin_name, family (Solanaceae, Brassicaceae, etc. — useful for rotation)
- category: vegetable/fruit/grain/legume/herb/cover/forage/flower/other
- days_to_maturity (consumed by farm.planting._compute_expected_harvest_date)
- image (auto-sized 128px variant for kanban)

5 tests.

* feat(farm_field): fields/plots with multi-company isolation

farm.field models a plot of land. Inherits farm.mixin (color/notes/mail.thread).

Fields:
- name, code (used on signage), farm_partner_id, company_id
- acres (manual; farm_field_geo will compute from polygon)
- crop_id (current crop), season_id, organic_certified (tracked)

Multi-company:
- _check_company_auto = True
- ir.rule scopes [company_id IN env.company_ids] globally
- security covered by test (user in company A blocked from company B's field)

6 tests including multi-company isolation.

* feat(farm_planting): planting events with state machine + multi-company

farm.planting records a (field, crop, date) tuple. State machine walks through planted → growing → harvested|failed. Expected harvest date auto-computes from crop.days_to_maturity (overrideable).

Multi-company: company_id is related to field_id.company_id, store=True + index=True + precompute=True (NOT NULL at INSERT so ir.rule binds correctly). ir.rule scoping by company_id. field_id is check_company=True.

9 tests including precompute and date-constraint checks.

* feat(farm_harvest): harvest events with auto-fill from planting

farm.harvest logs quantity + UoM + date for each pick. Two flows: (1) from a planting — field/crop auto-fill via precompute=True compute, locked readonly in the form; (2) standalone — manual field/crop entry for retroactive records.

Multi-company: company_id related to field.company_id, precompute=True. ir.rule scoping. check_company=True on field_id.

Optional grade (A/B/C/compost) for tiered pricing downstream.

6 tests including stale field_id behavior when planting cleared.

* fix: kanban templates for Odoo 19 Card system

The Card template introduced in Odoo 17+ doesn't support the legacy wrappers (`oe_kanban_details`, `o_kanban_image_fill_left`) or the `highlight_color` attribute, and the `t-if="record.X.raw_value"` conditional pattern that worked in v18 raises an OwlError at mount time.

Rewrite all four kanbans in the simplified Card style (mirrors farm_egg_production): drop wrapper divs, drop `highlight_color`, replace conditional t-if with bare `<field>` references that render empty when null. Verified against fresh 19.0 DB — 0 page errors, all records render.

* feat(farm_field_geo): PostGIS polygon + auto-computed acreage

Extends farm.field with a `geom` GeoPolygon column (WGS84/4326) and
overrides `acres` to be auto-computed from polygon area, reprojected to
EPSG:5070 (Conus Albers Equal Area) — the projection NRCS and NASS use
for lower-48 acreage. Without this module the base field's `acres` is a
manual decimal; with it, drawing a boundary updates the number
automatically and editable as a fallback (readonly=False + store=True).

Depends on OCA/geospatial's `base_geoengine`. That module isn't on the
upstream 19.0 branch yet — workspace `repos.yaml` forward-port-pins to
OCA PR #446. Reverts to plain `oca 19.0` once that lands.

In-form polygon EDITING needs `web_leaflet_draw_lib`, which has no 19.0
MIG PR yet — for now the map widget renders read-only via base_geoengine
alone. Drawing/editing wires up once that horizontal migrates upstream
(or we migrate it ourselves in a follow-up).

* refactor(farm_field_geo): self-review fixes

Self-review against feature-completeness + DRY + test-coverage + docs:

- View: move the geom widget from after-acres (inside a 2-column group, where
  the map gets crushed) to its own Boundary notebook tab where it can use
  full width. Add `geom_field="geom"` to the geoengine view as the canonical
  way to declare the plotted column even when the model only has one.
- Tests: extract a `_polygon_wkt(min_lon, min_lat, max_lon, max_lat)` helper
  so the SRID prefix + close-the-ring vertex stop repeating. Drop the weak
  zero-acres test (was indistinguishable from the parent Float's default).
  Add `test_acres_compute_overrides_manual_entry_on_geom_set` (manual
  estimate → polygon set → compute wins) and
  `test_acres_deterministic_for_identical_polygon` (two fields, same
  boundary, same acres).
- USAGE.md: untangle the contradictory "draw … read-only" wording. Make the
  manual-acres-as-fallback flow explicit.
- DESCRIPTION.md: add Scope (multi-plot fields → multiple farm.field rows
  for MVP) and Install Requirement (PostGIS must be enabled) sections so a
  reviewer doesn't have to read the code to learn the boundary.

* feat(farm_field_overlays): USDA Cropland + NRCS Soil + OSM overlays

Adds three public-domain overlay raster layers to the farm.field map:

- USDA Cropland (CDL): WMS, current-year crop classification raster.
  Layer name is year-specific (`cdl_YYYY`); USAGE.md documents the
  annual-bump procedure once the new year's CDL publishes.
- NRCS SSURGO Soil: WMS, soil mapunit polygons covering CONUS.
- OpenStreetMap basemap: tile-server backdrop so roads + parcels show
  through.

All three are read-only, public-domain US government services. No API
keys, no per-request quota. Stored as `geoengine.raster.layer` records
bound to `farm_field_geo.farm_field_view_geoengine`, so admins can
disable, reorder, or re-point them via Settings → Technical →
Geoengine → Raster Layers without touching code (`noupdate="1"` keeps
admin edits across module upgrades).

Three smoke tests verify the records survive install + carry the
required schema (correct view binding, LAYERS param on the WMS records,
overlay=False on the basemap).

* feat(farm_observation): geotagged field observations w/ urgency triage

New model `farm.observation` for capturing what's happening in each field:
type (pest/disease/weed/soil/water/yield/photo/other), free-text notes,
optional GeoPoint location, urgency (low/med/high), optional photo
attachment, mail.thread for chatter. Auto-named from field+type+date.

Views: list (color-coded by urgency), urgency-grouped kanban, form with
chatter + map widget on a Location tab, search with last-7-days +
high-urgency canned filters, geoengine map view that drops pins on the
field map.

Self-review fixes baked in before commit:
- `_order` would alpha-sort selection keys ("med" > "high"); fixed via a
  stored computed `urgency_rank` integer + regression test that asserts
  the actual priority order
- Dropped `widget="many2one_avatar"` on `photo_id` (the avatar widget
  is for partner-style records, not ir.attachment)

Deferred: EXIF GPS auto-population from photo uploads (needs an OWL JS
helper that parses files client-side — separate PR when a field partner
asks).

* feat(farm_water_source): wells, ponds, streams + which fields they serve

New `farm.water.source` model. Tracks the farm's water infrastructure with
its location, capacity, last-tested date, and a many2many of fields each
source serves. `geom` is `GeoMultiGeometry` so one column accepts the
shape that matches the type — point for well/trough/spring/hydrant,
linestring for stream, polygon for pond/tank.

Views: list (sum capacity), form (notebook for quality notes + location
map), search with "not tested in 1 year" canned filter, geoengine map
view showing every source on the field map.

Four tests cover all three geometry shapes (point/line/polygon) on the
same column and the field_ids many2many lookup that answers "what
fields does this source serve?".

* feat(farm_fence): fence lines + condition tracking + length compute

New `farm.fence` model. Fence type (7 options), height, condition with
mail.thread tracking, last-checked date, primary field link (nullable
for perimeter fences), and a `length_feet` auto-computed from the
polyline geometry — reprojected to EPSG:5070 Albers and converted from
meters to US survey feet to match NRCS rangeland-improvement reporting.

Self-review fix baked in:
- `_order = "condition desc"` would alpha-sort "repair > good > fair",
  hiding fair-condition fences below good ones. Added a stored computed
  `condition_rank` integer; `_order` uses that. Regression test
  asserts the actual urgency order.

Views: list (color-coded by condition), form with chatter + Fence Line
notebook tab, search with "needs repair" + "not checked in 6 months"
canned filters, geoengine map view.

Five tests: length compute (zero / from polyline / recompute on change),
condition sort regression, chatter tracking.

* refactor(farm_fence): self-review — company guard, archive, ondelete test

Self-review pass against the v1 geo slice. Three findings on farm_fence:

- Multi-company isolation wasn't enforced at write — a user in company A
  could have written a fence referencing a field in company B without
  the framework catching it. `_check_company_auto = True` on the model +
  `check_company=True` on `field_id` fixes it. (Same fix applied to
  farm_observation on its own branch.)

- No `active` field — fences get removed or replaced over time. Without
  archive support the only way to retire a fence was unlink, which loses
  history. Adds `active=True` with `boolean_toggle` widget on the form +
  an Archived filter on the search view. Mirrors farm_water_source.

- The `ondelete='set null'` behavior on `field_id` (perimeter fences
  survive their field's deletion) was an undocumented invariant. Added
  `test_field_unlink_sets_field_id_null_not_cascade` so a future ondelete
  change can't silently break it.

* fix(farm_fence): pre-empt all cascade gotchas — Alpha, shapely, pyproj, view RNG

Bundle of fixes learned across PR #7/#3/#4/#5 cascade:
- development_status=Alpha (OCA check-dev-status gate)
- Drop bogus 'code' field from farm.crop fixture
- Replace EWKT LineString strings with shapely.LineString
  (base_geoengine's GeoLineString expects shapely or EWKB hex)
- Switch reprojection from .transform() (Django-style, doesn't exist on
  shapely) to pyproj.Transformer + shapely.ops.transform — mirrors
  farm_field_geo's pattern
- Declare pyproj + shapely in external_dependencies.python
- Unwrap <group string='Group By' expand='0'> in search view
  (Odoo 19 RNG rejects both attributes on <group>)
- Replace flaky test_condition_tracking (mail.thread plumbing) with a
  field-definition probe — same approach as farm_observation

* fix(farm_fence): GeoLineString → GeoLine for base_geoengine 19.0

base_geoengine 19.0 renames the linestring field type to GeoLine
(dropped the 'String' suffix). AttributeError: module 'odoo.fields'
has no attribute 'GeoLineString'.

Author: dnplkndll

farm_fence/README.rst

@@ -0,0 +1,116 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
+==========
+Farm Fence
+==========
+
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:171f636929817374863dbdf0c0d452afdc46cc06088475d08a8ef94f19f96cc9
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Alpha
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-ledoent%2Ffarm--pack-lightgray.png?logo=github
+    :target: https://github.com/ledoent/farm-pack/tree/19.0/farm_fence
+    :alt: ledoent/farm-pack
+
+|badge1| |badge2| |badge3|
+
+Tracks fence lines on the farm with type (barbed wire, high-tensile,
+electric, post-and-rail, woven wire, polywire, temporary), height,
+condition (good / fair / needs repair), last-checked date, and an
+auto-computed length in feet from the polyline geometry.
+
+``length_feet`` mirrors the acreage compute in ``farm_field_geo``: the
+WGS84 polyline is reprojected to **EPSG:5070 Conus Albers Equal Area**
+and the geodesic length in meters is converted to US survey feet
+(0.3048006096012192 m/ft). The number matches what NRCS would report for
+the same fence line in a rangeland improvement filing.
+
+Repairs-needed bubble to the top of every list and grouped kanban
+because ``_order`` uses a stored computed ``condition_rank`` integer
+mirroring the selection — a naive string DESC would put "good" above
+"fair" (alpha order).
+
+Field link is optional (``ondelete="set null"``) so a perimeter fence
+spanning multiple fields keeps its history even when one field is
+archived or deleted.
+
+.. IMPORTANT::
+   This is an alpha version, the data model and design can change at any time without warning.
+   Only for development or testing purpose, do not use in production.
+   `More details on development status <https://odoo-community.org/page/development-status>`_
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Usage
+=====
+
+1. Open Farm → Fences.
+2. Click **New** and pick a fence type + height.
+3. Optional: link a primary field. Leave blank for perimeter fences.
+4. Open the **Fence Line** tab and trace the fence on the map.
+5. Save. **Length (feet)** auto-computes from the polyline.
+
+Day-to-day:
+
+- **Walk-the-fence rotation**: filter by "Not Checked in 6 Months" to
+  plan the next inspection sweep.
+- **Repair triage**: kanban grouped by Condition puts Needs Repair at
+  the top so you can plan the materials run before the weekend.
+- **Materials estimate**: open a fence record, read Length (feet),
+  multiply by the wire / post spec to size the order.
+- **Insurance / NRCS reporting**: switch to the Map view to print a
+  screenshot of the entire fencing system colored by type, with each
+  fence's length in the legend.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/ledoent/farm-pack/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+`feedback <https://github.com/ledoent/farm-pack/issues/new?body=module:%20farm_fence%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+-------
+
+* Ledo Enterprises
+
+Contributors
+------------
+
+- Daniel Kendall <dkendall@ledoweb.com>
+
+Maintainers
+-----------
+
+.. |maintainer-dnplkndll| image:: https://github.com/dnplkndll.png?size=40px
+    :target: https://github.com/dnplkndll
+    :alt: dnplkndll
+
+Current maintainer:
+
+|maintainer-dnplkndll| 
+
+This module is part of the `ledoent/farm-pack <https://github.com/ledoent/farm-pack/tree/19.0/farm_fence>`_ project on GitHub.
+
+You are welcome to contribute.

farm_fence/__init__.py

@@ -0,0 +1 @@
+from . import models

farm_fence/__manifest__.py

@@ -0,0 +1,26 @@
+{
+    "name": "Farm Fence",
+    "version": "19.0.1.0.0",
+    "summary": "Fence lines + condition tracking + auto-computed length",
+    "author": "Ledo Enterprises, Odoo Community Association (OCA)",
+    "maintainers": ["dnplkndll"],
+    "website": "https://github.com/ledoent/farm-pack",
+    "license": "AGPL-3",
+    "category": "Vertical/Agriculture",
+    # Alpha matches farm_field_geo's chain — OCA check-dev-status gate.
+    "development_status": "Alpha",
+    "depends": [
+        "farm_field_geo",
+        "mail",
+    ],
+    "external_dependencies": {
+        "python": ["pyproj", "shapely"],
+    },
+    "data": [
+        "security/ir.model.access.csv",
+        "views/farm_fence_views.xml",
+        "views/farm_fence_menu.xml",
+    ],
+    "installable": True,
+    "application": False,
+}

farm_fence/models/__init__.py

@@ -0,0 +1 @@
+from . import farm_fence

farm_fence/models/farm_fence.py

@@ -0,0 +1,127 @@
+from functools import lru_cache
+
+from pyproj import Transformer
+from shapely.ops import transform as shapely_transform
+
+from odoo import api, fields, models
+
+# US survey foot in meters. Used to convert EPSG:5070 length (m) to feet
+# for display — US farm fencing is universally specified in feet.
+M_PER_US_SURVEY_FOOT = 0.3048006096012192
+
+# Selection keys are descriptive strings (good/fair/repair) for the UI, but
+# alpha-DESC would order "repair > good > fair" — fair-condition fences
+# would hide below good-condition ones. `condition_rank` mirrors the
+# selection so `_order` produces the actual urgency sort.
+_CONDITION_RANK = {"good": 0, "fair": 1, "repair": 2}
+
+
+@lru_cache(maxsize=1)
+def _wgs84_to_albers_conus():
+    """Build the EPSG:4326 → EPSG:5070 transformer once and reuse it.
+
+    Same approach farm_field_geo uses for acreage — Albers reprojection
+    gives a length number that matches what NRCS reports for the same
+    fence in a rangeland-improvement filing.
+    """
+    return Transformer.from_crs("EPSG:4326", "EPSG:5070", always_xy=True).transform
+
+
+class FarmFence(models.Model):
+    _name = "farm.fence"
+    _description = "Fence"
+    _inherit = ["mail.thread"]
+    # Repairs-needed bubble to the top.
+    _order = "condition_rank desc, name"
+    # Enforces field_id.company_id == fence.company_id at write time (only
+    # checked when field_id is set; perimeter fences with a null field_id
+    # pass through).
+    _check_company_auto = True
+
+    name = fields.Char(required=True, tracking=True)
+    active = fields.Boolean(
+        default=True,
+        help="Untick to archive fences that have been removed or replaced. "
+        "Their geometry and history stay on the field map's archived view.",
+    )
+    field_id = fields.Many2one(
+        "farm.field",
+        string="Primary Field",
+        help="Field this fence belongs to. Leave blank for perimeter fences "
+        "that span multiple fields.",
+        ondelete="set null",
+        check_company=True,
+    )
+    geom = fields.GeoLine(
+        string="Fence Line",
+        srid=4326,
+        help="Polyline tracing the fence. Length and the map view come from "
+        "this geometry. base_geoengine 19.0 names the type GeoLine (no "
+        "'String' suffix).",
+    )
+    length_feet = fields.Float(
+        compute="_compute_length_feet",
+        store=True,
+        digits=(10, 1),
+        help="Auto-computed from the polyline length, reprojected to "
+        "EPSG:5070 (Albers Equal Area) and converted from meters to US "
+        "survey feet.",
+    )
+    fence_type = fields.Selection(
+        [
+            ("barbed_wire", "Barbed Wire"),
+            ("high_tensile", "High-Tensile"),
+            ("electric", "Electric"),
+            ("post_rail", "Post & Rail"),
+            ("woven_wire", "Woven Wire"),
+            ("polywire", "Polywire (rotational)"),
+            ("temporary", "Temporary"),
+        ],
+        required=True,
+        tracking=True,
+    )
+    height_inches = fields.Float(digits=(5, 1))
+    condition = fields.Selection(
+        [
+            ("good", "Good"),
+            ("fair", "Fair"),
+            ("repair", "Needs Repair"),
+        ],
+        default="good",
+        required=True,
+        tracking=True,
+    )
+    condition_rank = fields.Integer(
+        compute="_compute_condition_rank",
+        store=True,
+        index=True,
+        help="Numeric mirror of condition so _order produces an urgency sort "
+        "(string DESC on selection keys would put 'good' above 'fair').",
+    )
+    last_checked_date = fields.Date(tracking=True)
+    notes = fields.Text()
+    company_id = fields.Many2one(
+        "res.company",
+        required=True,
+        default=lambda self: self.env.company,
+        index=True,
+    )
+
+    @api.depends("condition")
+    def _compute_condition_rank(self):
+        for rec in self:
+            rec.condition_rank = _CONDITION_RANK.get(rec.condition, 0)
+
+    @api.depends("geom")
+    def _compute_length_feet(self):
+        # base_geoengine returns the field as a plain shapely geometry on
+        # read; shapely has no .transform() method. Reproject via pyproj +
+        # shapely.ops.transform before measuring length. Mirrors the
+        # acreage compute in farm_field_geo.
+        transformer = _wgs84_to_albers_conus()
+        for rec in self:
+            if not rec.geom:
+                rec.length_feet = 0.0
+                continue
+            projected = shapely_transform(transformer, rec.geom)
+            rec.length_feet = projected.length / M_PER_US_SURVEY_FOOT

farm_fence/pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

farm_fence/readme/CONTRIBUTORS.md

@@ -0,0 +1 @@
+- Daniel Kendall <dkendall@ledoweb.com>

farm_fence/readme/DESCRIPTION.md

@@ -0,0 +1,19 @@
+Tracks fence lines on the farm with type (barbed wire, high-tensile,
+electric, post-and-rail, woven wire, polywire, temporary), height,
+condition (good / fair / needs repair), last-checked date, and an
+auto-computed length in feet from the polyline geometry.
+
+`length_feet` mirrors the acreage compute in `farm_field_geo`: the
+WGS84 polyline is reprojected to **EPSG:5070 Conus Albers Equal Area**
+and the geodesic length in meters is converted to US survey feet
+(0.3048006096012192 m/ft). The number matches what NRCS would report
+for the same fence line in a rangeland improvement filing.
+
+Repairs-needed bubble to the top of every list and grouped kanban
+because `_order` uses a stored computed `condition_rank` integer
+mirroring the selection — a naive string DESC would put "good" above
+"fair" (alpha order).
+
+Field link is optional (`ondelete="set null"`) so a perimeter fence
+spanning multiple fields keeps its history even when one field is
+archived or deleted.

farm_fence/readme/USAGE.md

@@ -0,0 +1,17 @@
+1. Open Farm → Fences.
+2. Click **New** and pick a fence type + height.
+3. Optional: link a primary field. Leave blank for perimeter fences.
+4. Open the **Fence Line** tab and trace the fence on the map.
+5. Save. **Length (feet)** auto-computes from the polyline.
+
+Day-to-day:
+
+- **Walk-the-fence rotation**: filter by "Not Checked in 6 Months" to plan
+  the next inspection sweep.
+- **Repair triage**: kanban grouped by Condition puts Needs Repair at the
+  top so you can plan the materials run before the weekend.
+- **Materials estimate**: open a fence record, read Length (feet), multiply
+  by the wire / post spec to size the order.
+- **Insurance / NRCS reporting**: switch to the Map view to print a screenshot
+  of the entire fencing system colored by type, with each fence's length
+  in the legend.