[MIG] database_size: Migration to 19.0

- read_group override → _read_group (19.0 deprecated public read_group + web no longer routes through it). New signature (groupby/aggregates/having/order); still defaults the group order for the report views.
- search view: dropped `expand`/`string` from the Group By <group> (19.0 RelaxNG rejects them on search-view groups).
- _sql_constraints → models.Constraint (kept uniq_model_measurement_date name).
- report: f-strings inside self.env._() → %(name)s placeholders (19.0 pylint translation-fstring-interpolation).
- _compute_model_name: justified `# pylint: disable=no-search-all` (small ir.model registry load).

Signed-off-by: Don Kendall <dkendall@ledoweb.com>

Author: dnplkndll

database_size/models/ir_model_size.py

@@ -13,13 +13,10 @@ class IrModelSize(models.Model):
     _description = "Disk space usage per model"
     _order = "measurement_date desc, total_model_size desc"
     _rec_name = "model"
-    _sql_constraints = [
-        (
-            "uniq_model_measurement_date",
-            "unique(model, measurement_date)",
-            "There is already a measurement for this model on the given date",
-        ),
-    ]
+    _uniq_model_measurement_date = models.Constraint(
+        "unique(model, measurement_date)",
+        "There is already a measurement for this model on the given date",
+    )
     model = fields.Char(index=True)
     model_name = fields.Char(
         compute="_compute_model_name",
@@ -84,32 +81,40 @@ class IrModelSize(models.Model):
     def _compute_model_name(self):
         """Assign the model's label"""
         model2name = {
-            model.model: model.name for model in self.env["ir.model"].sudo().search([])
+            model.model: model.name
+            for model in self.env["ir.model"].sudo().search([])  # pylint: disable=no-search-all
         }
         for size in self:
             size.model_name = model2name.get(size.model, "<removed>")
 
     @api.model
-    def read_group(
-        self, domain, fields, groupby, offset=0, limit=None, orderby=False, lazy=True
+    def _read_group(
+        self,
+        domain,
+        groupby=(),
+        aggregates=(),
+        having=(),
+        offset=0,
+        limit=None,
+        order=None,
     ):
         """Enforce that grouped results are ordered.
 
-        Odoo will happily use the grouping field for ordering unless groupby is a
-        list, and as it happens the grouping is usually passed as a list, for
-        example: ['measurement_date:day']
+        When the caller doesn't pass an explicit order, default to the first
+        groupby field descending (e.g. ['measurement_date:day']) so the
+        size-report views stay sorted.
         """
-        if not orderby and groupby and isinstance(groupby, list | set):
+        if not order and groupby:
             field = groupby[0].split(":")[0]
-            orderby = f"{field} desc"
-        return super().read_group(
+            order = f"{field} desc"
+        return super()._read_group(
             domain,
-            fields,
             groupby,
+            aggregates,
+            having,
             offset=offset,
             limit=limit,
-            orderby=orderby,
-            lazy=lazy,
+            order=order,
         )
 
     @api.depends(

database_size/report/ir_model_size_report.py

@@ -85,17 +85,21 @@ def _move_dates_to_context(self, domain):
                 if field in values:
                     raise UserError(
                         self.env._(
-                            f"You cannot search on more than one value for {field} "
-                            "at the same time."
+                            "You cannot search on more than one value for"
+                            " %(field)s at the same time.",
+                            field=field,
                         )
                     )
                 if clause[1] in ("=", "==") and clause[2]:
                     values[field] = clause[2]
                 else:
                     raise UserError(
                         self.env._(
-                            f"Searching {field} for '{clause[1]} {clause[2]}' is "
-                            "not supported."
+                            "Searching %(field)s for '%(operator)s %(value)s'"
+                            " is not supported.",
+                            field=field,
+                            operator=clause[1],
+                            value=clause[2],
                         )
                     )
                 new_domain.append((1, "=", 1))
@@ -138,8 +142,8 @@ def _table_query(self):
             ):
                 raise UserError(
                     self.env._(
-                        "There is no data from "
-                        f"{fields.Date.to_string(measurement_date)}"
+                        "There is no data from %(date)s",
+                        date=fields.Date.to_string(measurement_date),
                     )
                 )
         else:
@@ -165,8 +169,8 @@ def _table_query(self):
             ):
                 raise UserError(
                     self.env._(
-                        "There is no data from "
-                        f"{fields.Date.to_string(historical_measurement_date)}"
+                        "There is no data from %(date)s",
+                        date=fields.Date.to_string(historical_measurement_date),
                     )
                 )
         else:

database_size/views/ir_model_size_views.xml

@@ -5,7 +5,7 @@
         <field name="arch" type="xml">
             <search>
                 <field name="model" />
-                <group expand="0" string="Group By">
+                <group>
                     <filter
                         string="Date of Measurement"
                         name="group_measurement_date"