polish(notifications): assert deterministic notif id, cap pending map, align foreground semantics

Author: leduckhc

app/lib/notifications/notification_observer.dart

@@ -41,7 +41,13 @@ class NotificationController with WidgetsBindingObserver {
 
   @override
   void didChangeAppLifecycleState(AppLifecycleState state) {
-    _foreground = state == AppLifecycleState.resumed;
+    // `inactive` (a transient system overlay: control center, app switcher,
+    // call banner) still counts as foreground — the user is effectively in-app,
+    // so a status notification would be redundant. This mirrors
+    // `SrvRequestHandler`'s foreground semantics.
+    _foreground =
+        state == AppLifecycleState.resumed ||
+        state == AppLifecycleState.inactive;
   }
 
   void _onSessions(SessionsState sessions) {

app/lib/ui/widgets/srv_request_handler.dart

@@ -36,8 +36,11 @@ class _SrvRequestHandlerState extends ConsumerState<SrvRequestHandler>
 
   /// Backgrounded requests for which we fired a notification. Kept so that if
   /// the user resumes the app without acting on the notification, we can still
-  /// present the dialog (the `srvRequests` stream has no replay).
+  /// present the dialog (the `srvRequests` stream has no replay). Soft-capped
+  /// so a long backgrounded session can't grow it without bound (mirrors the
+  /// SPEC-07 status-notification queue); oldest entries are evicted first.
   final Map<String, Envelope> _pendingBackground = {};
+  static const _kMaxPendingBackground = 50;
 
   /// Salted so request-notification ids can't collide with the status
   /// notifications keyed on `sessionId.hashCode`.
@@ -124,6 +127,9 @@ class _SrvRequestHandlerState extends ConsumerState<SrvRequestHandler>
         // Not shown (no permission / dismissed / platform throw): fall through
         // to present the dialog now, so the request stays answerable.
         if (shown) {
+          if (_pendingBackground.length >= _kMaxPendingBackground) {
+            _pendingBackground.remove(_pendingBackground.keys.first);
+          }
           _pendingBackground[env.id] = env;
           return;
         }

app/test/srv_request_handler_notify_test.dart

@@ -22,7 +22,7 @@ class _RecordingNotificationService extends NotificationService {
   /// Value returned from [show] — set to `false` to simulate a notification
   /// that could not be displayed (no permission / dismissed / platform throw).
   final bool result;
-  final List<({String? category, String? payload})> shown = [];
+  final List<({int id, String? category, String? payload})> shown = [];
 
   @override
   Future<bool> show({
@@ -32,7 +32,7 @@ class _RecordingNotificationService extends NotificationService {
     String? payload,
     String? category,
   }) async {
-    shown.add((category: category, payload: payload));
+    shown.add((id: id, category: category, payload: payload));
     return result;
   }
 }
@@ -362,4 +362,43 @@ void main() {
       expect(find.text('Approve'), findsNothing);
     },
   );
+
+  testWidgets(
+    'notification id is deterministic per requestId and differs across requests',
+    (tester) async {
+      final (transport, notifications, _) = await pumpHandler(tester);
+      tester.binding.handleAppLifecycleStateChanged(AppLifecycleState.paused);
+      await tester.pump();
+
+      Envelope confirm(String id) => Envelope(
+        t: MsgType.srvRequest,
+        id: id,
+        body: {
+          'kind': 'confirmAction',
+          'action': 'rm -rf build/',
+          'sessionId': 's1',
+        },
+      );
+
+      // Same env.id dispatched twice → same notification id (OS dedup).
+      transport.emit(confirm('req-same'));
+      await tester.pump();
+      await tester.pump();
+      transport.emit(confirm('req-same'));
+      await tester.pump();
+      await tester.pump();
+
+      // Different env.id → different notification id.
+      transport.emit(confirm('req-other'));
+      await tester.pump();
+      await tester.pump();
+
+      expect(notifications.shown, hasLength(3));
+      final firstId = notifications.shown[0].id;
+      final secondId = notifications.shown[1].id;
+      final otherId = notifications.shown[2].id;
+      expect(secondId, firstId);
+      expect(otherId, isNot(firstId));
+    },
+  );
 }