Commit 66c85fb
feat(app): SPEC-03 Phase 1 — macOS desktop control app foundations (#11)
* docs: mark SPEC-02 done, add SPEC-03 architecture & parallel plan
- SPEC-02 (CLI client subcommands): all acceptance criteria met, marked complete
- SPEC-03: design → implementation phase
- Added SPEC-03-ARCHITECTURE-AND-PLAN.md with:
- Flutter desktop (macOS) reuse rationale
- Layered architecture (control-plane socket client + desktop UI + shared store)
- 7 tasks with parallel breakdown (3-4 subagents, Phase 1-3 timeline)
- Tech decision points (menubar lib, socket client, cert trust, daemon spawn)
- Success criteria + known constraints
- ~8-10 hrs estimated effort
- All tasks gated for mobile compat, no changes to mobile build
* feat(app): SPEC-03 Phase 1 — macOS desktop control app foundations
Parallel Phase 1 work for SPEC-03 (macOS desktop control app).
Three independent streams delivered in worktrees:
Stream A — Control client (app/lib/control/)
- control_types.dart: wire-protocol data classes (StatusData,
PairMintData, DeviceInfo, LogChunk, ControlResponse) mirroring
server/src/daemon/protocol.ts verbs (status, pair.mint/current,
devices.list/revoke, sessions.list, server.stop, logs.tail).
- control_codec.dart: NDJSON encode/decode, decodeResponse yields
null on malformed input.
- control_client.dart: PinoControlClient over a Unix-domain socket
(~/.pino/control.sock). Injectable connector + id generator.
id-correlated request/response with timeout, streaming
tailLogs, convenience methods per verb.
- 44 tests (codec round-trip + client behaviour).
Stream B — Menubar tray (app/lib/desktop/tray/)
- tray_controller.dart: TrayController (ChangeNotifier) with
TrayPlatform seam for testability. init/update/dispose, full
menu structure (Start/Stop, Dashboard, Pair QR, Devices(N),
Sessions(N), Quit), macOS Platform.isMacOS guards on every
tray_manager call, DaemonSummary model.
- tray_icons.dart: default tray icon path.
- 10 tests with FakeTrayPlatform.
Stream C — Desktop screens (app/lib/desktop/screens/)
- control_contract.dart: abstract ControlClient + plain DTOs the
screens depend on (decoupled from Stream A's wire types;
bridged at Phase-4 app root).
- 5 screens: status_screen, qr_screen (QrImageView + countdown),
devices_screen (revoke), sessions_screen, session_log_screen
(streaming with auto-scroll + manual-scroll-pause).
- providers.dart: controlClientProvider placeholder.
- time_format.dart: formatUptime/formatCountdown/formatRelative.
- fake_control_client.dart: injectable canned client.
- 18 widget tests covering data/empty/error/interaction.
Dependencies added to pubspec.yaml (native plugins pinned exactly):
- tray_manager 0.5.3 (leanflutter.dev)
- window_manager 0.5.1 (leanflutter.dev)
- qr_flutter ^4.1.0 (theyakka.com, pure-Dart)
Verification:
- flutter analyze --fatal-infos (entire app/): No issues found
- flutter test lib/control/ + lib/desktop/: 72/72 pass
- server pnpm test (181/181) + typecheck: clean
Companion to docs/SPEC-03-ARCHITECTURE-AND-PLAN.md.
See also: SPEC-03 status updated to 'design → implementation'.
* style(app): run `dart format` on SPEC-03 Phase 1 files
CI `lint-and-analyze` job failed: `dart format` reported
"Formatted 68 files (14 changed)". This commit applies the
formatter to all files under `app/lib/control/` and
`app/lib/desktop/` to reach zero diff.
No semantic changes; `flutter analyze --fatal-infos` and all 72
tests remain green.
* fix(app): align control client contract
* fix(app): resolve PR review follow-ups
* fix(app): harden control client lifecycle and log streaming
- guard connect() against double-connect and reconnect-after-dispose so
the previous socket + subscription can no longer leak
- bound the inbound NDJSON buffer (1 MiB) so a newline-less local peer
cannot grow it without limit
- surface a socket drop as a stream error for follow tailLogs consumers
instead of a silent clean EOF; non-follow tails still close cleanly
- remove dead decodeTypedResponse codec helper
- add regression tests for each
Co-authored-by: Milan Le <leduckhc@users.noreply.github.com>
* fix(app): make TrayController platform gate testable
Introduce an injectable isMacOS seam (defaulting to Platform.isMacOS) so
the guarded init/update/dispose paths run under test on non-macOS CI.
Previously every tray_manager call was skipped on Linux, leaving all tray
assertions checking empty state against non-empty expectations. Add a
no-op-off-macOS test.
Co-authored-by: Milan Le <leduckhc@users.noreply.github.com>
* fix(app): guard desktop screens against use-after-dispose
- qr_screen: check mounted after each await before starting the countdown
ticker so a disposed screen cannot leave a Timer.periodic running
- session_log_screen: bail out of the post-frame auto-scroll callback when
no longer mounted, avoiding asserts on a disposed ScrollController
Co-authored-by: Milan Le <leduckhc@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Milan Le <leduckhc@users.noreply.github.com>1 parent 624df25 commit 66c85fb
23 files changed
Lines changed: 3758 additions & 3 deletions
File tree
- app
- lib
- control
- desktop
- screens
- tray
- server/src/daemon
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
0 commit comments