Make thinking tokens selectable when expanded (#45)

* Make thinking tokens selectable when expanded

Expanded thinking cards now use SelectableText so text can be dragged to
select/copy. A plain tap (no drag) still collapses the card via
SelectableText's onTap, while the collapsed state keeps its tap-to-expand
InkWell.

* Restore thinking card accessibility

Author: leduckhc

app/lib/ui/session/session_screen.dart

@@ -490,31 +490,42 @@ class _ThinkingCardState extends State<_ThinkingCard> {
       fontStyle: FontStyle.italic,
       height: 1.3,
     );
-    return InkWell(
-      onTap: () => setState(() => _expanded = !_expanded),
-      child: Padding(
-        padding: const EdgeInsets.fromLTRB(16, 4, 16, 4),
-        child: Row(
-          crossAxisAlignment: CrossAxisAlignment.start,
-          children: [
-            Icon(
-              Icons.psychology_outlined,
-              size: 15,
-              color: cs.onSurfaceVariant.withValues(alpha: 0.55),
-            ),
-            const SizedBox(width: 6),
-            Expanded(
-              child: Text(
-                widget.text.trim(),
-                style: style,
-                maxLines: _expanded ? null : 1,
-                overflow: _expanded ? TextOverflow.clip : TextOverflow.ellipsis,
-              ),
-            ),
-          ],
-        ),
+    void toggle() => setState(() => _expanded = !_expanded);
+    final row = Padding(
+      padding: const EdgeInsets.fromLTRB(16, 4, 16, 4),
+      child: Row(
+        crossAxisAlignment: CrossAxisAlignment.start,
+        children: [
+          Icon(
+            Icons.psychology_outlined,
+            size: 15,
+            color: cs.onSurfaceVariant.withValues(alpha: 0.55),
+          ),
+          const SizedBox(width: 6),
+          Expanded(
+            child: _expanded
+                // When expanded the text is selectable. A plain tap (no drag)
+                // still collapses the card; dragging selects text instead.
+                ? SelectableText(
+                    widget.text.trim(),
+                    style: style,
+                    onTap: toggle,
+                  )
+                : Text(
+                    widget.text.trim(),
+                    style: style,
+                    maxLines: 1,
+                    overflow: TextOverflow.ellipsis,
+                  ),
+          ),
+        ],
       ),
     );
+    // Collapsed: whole row is a tap target that expands. Expanded: rely on
+    // SelectableText's onTap so selecting text doesn't collapse the card.
+    return _expanded
+        ? Semantics(onTap: toggle, onTapHint: 'Collapse thinking', child: row)
+        : InkWell(onTap: toggle, child: row);
   }
 }
 

app/test/session_screen_test.dart

@@ -0,0 +1,98 @@
+import 'dart:ui' show SemanticsAction;
+
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:flutter_secure_storage/flutter_secure_storage.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:makit/store/connection.dart';
+import 'package:makit/store/models.dart';
+import 'package:makit/store/store.dart';
+import 'package:makit/ui/session/session_screen.dart';
+
+class _EmptyStorage extends FlutterSecureStorage {
+  const _EmptyStorage() : super();
+
+  @override
+  Future<String?> read({
+    required String key,
+    AppleOptions? iOptions,
+    AndroidOptions? aOptions,
+    LinuxOptions? lOptions,
+    WebOptions? webOptions,
+    AppleOptions? mOptions,
+    WindowsOptions? wOptions,
+  }) async => null;
+
+  @override
+  Future<void> write({
+    required String key,
+    required String? value,
+    AppleOptions? iOptions,
+    AndroidOptions? aOptions,
+    LinuxOptions? lOptions,
+    WebOptions? webOptions,
+    AppleOptions? mOptions,
+    WindowsOptions? wOptions,
+  }) async {}
+
+  @override
+  Future<void> delete({
+    required String key,
+    AppleOptions? iOptions,
+    AndroidOptions? aOptions,
+    LinuxOptions? lOptions,
+    WebOptions? webOptions,
+    AppleOptions? mOptions,
+    WindowsOptions? wOptions,
+  }) async {}
+}
+
+void main() {
+  testWidgets('expanded thinking can be collapsed through semantics', (
+    tester,
+  ) async {
+    const sessionId = 's1';
+    const thinking = 'A detailed reasoning trace';
+    final session = Session(
+      id: sessionId,
+      projectId: 'p1',
+      agent: 'pi',
+      title: 'Session',
+      status: SessionStatus.idle,
+      policy: ApprovalPolicy.askOnRisky,
+    );
+
+    await tester.pumpWidget(
+      ProviderScope(
+        overrides: [
+          connectionControllerProvider.overrideWith(
+            (ref) => ConnectionController(const _EmptyStorage()),
+          ),
+          projectsProvider.overrideWithValue(ProjectsState(const [])),
+          sessionsProvider.overrideWithValue(SessionsState([session])),
+          chatItemsProvider(
+            sessionId,
+          ).overrideWithValue([ThinkingItem(seq: 1, ts: 0, text: thinking)]),
+          sessionMetaProvider(sessionId).overrideWithValue(null),
+          sessionActionErrorProvider(sessionId).overrideWithValue(null),
+          commandsProvider(sessionId).overrideWithValue(const []),
+        ],
+        child: const MaterialApp(home: SessionScreen(sessionId: sessionId)),
+      ),
+    );
+    await tester.pump();
+
+    expect(find.byType(SelectableText), findsNothing);
+    await tester.tap(find.text(thinking));
+    await tester.pump();
+
+    final semantics = tester.getSemantics(find.byType(SelectableText));
+    expect(semantics.getSemanticsData().hasAction(SemanticsAction.tap), isTrue);
+
+    semantics.owner!.performAction(semantics.id, SemanticsAction.tap);
+    await tester.pump();
+
+    expect(find.byType(SelectableText), findsNothing);
+    await tester.pump(const Duration(milliseconds: 600));
+  });
+}