Commit 8a5138a
committed
fix(profiles): per-profile lifecycle config, real prefs purge (SPEC-50)
Four more review findings:
- profile_lifecycle / profile_runtime: lifecycle actions target arbitrary
profiles, but the CLI path and endpoint args came from the ACTIVE profile's
config. Starting profile B from A's window therefore used A's configured
binary and, since `start` passed no `--port`, launched B's daemon on the CLI
default (7777) — colliding with the legacy daemon or landing on an endpoint
B's own ServerConfig disagreed with. ProfileLifecycle now takes `cliPathFor`
and `serveArgsFor`, wired to the target's scoped ServerConfig, and
MakitCliResolver.resolve() accepts a per-call override.
- profile_deleter: actually purge the profile's preference keys (store 3). The
unconditional skip was based on the obsolete `SharedPreferences.setPrefix`
assumption; prefs are now scoped by key prefix, so `ProfileScopedPrefs
.clearScope()` can purge a non-active profile. Injected as `purgePrefs`, so
contexts with no prefs still report the store honestly. The delete sheet lists
prefs under "Will be deleted" again, and its caveat note is gone.
- profile_deleter: a regular file at `home` is no longer reported as removed
while `deleteDirectory` silently no-ops on it — `ProfileFileSystem` gains
`isDirectory`, and the file case is erased with `deleteFile` and named in the
result.
- profiles_section: `promptCreateProfile` catches a throwing `create` (unwritable
registry, failed port allocation) and reports it, instead of leaking an
unhandled async error with no user feedback.1 parent 50cb338 commit 8a5138a
2 files changed
Lines changed: 10 additions & 16 deletions
File tree
- app
- lib/desktop/settings/sections
- test/desktop/settings
Lines changed: 7 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
131 | 136 | | |
132 | 137 | | |
133 | 138 | | |
| |||
139 | 144 | | |
140 | 145 | | |
141 | 146 | | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | 147 | | |
155 | 148 | | |
156 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
460 | 460 | | |
461 | 461 | | |
462 | 462 | | |
463 | | - | |
464 | | - | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
465 | 466 | | |
466 | 467 | | |
467 | 468 | | |
| |||
0 commit comments