Skip to content

the loadMinimal logic may have a mistake #1374

@xiangjiu0918

Description

@xiangjiu0918

Which OS ?

windows

Version

Which versions are you using:

  • react-native-swiper v?1.6.0-rc.2
  • react-native v0.?.?0.73.0

Expected behaviour

​​​​The real last swiper should be keep
react-native-swiper1

Actual behaviour

The real penultimate swiper was kept.
swiper-screenshot

I read the source code and I think it's on line 836 should be 'loop && i === total ' instead ‘loop && i === total - 1’.

How to reproduce it>

<Swiper loadMinimal={true} loop={true}> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> </Swiper>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions