Skip to content
Discussion options

You must be logged in to vote

Thanks a lot for starting this discussion! From what I can see, the procedure looks mostly correct.

I'm a bit uncertain about the indices (flo and fhi) used to calculate ref_segment from ref, and later in the filter calculation.
In our implementation, they are defined as:

flo = size // 2 - length // 2
fhi = size // 2 + length // 2

I’d suggest using the functions already defined in the routine whenever possible, to ensure consistency.

A general comment about the filter: a flat top will be needed to properly calculate the energy.

For any further discussion, feel free to reach out at valerio.dandrea@lngs.infn.it

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by zql2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants