chore(CLI/SDK): change from using PATCH to correctly using GET for getTrigger

Author: LevinCeglie

cli/kleinkram/__init__.py

@@ -23,6 +23,7 @@
 from kleinkram.wrappers import get_project
 from kleinkram.wrappers import get_template
 from kleinkram.wrappers import get_template_revisions
+from kleinkram.wrappers import get_trigger
 from kleinkram.wrappers import launch_execution
 from kleinkram.wrappers import list_executions
 from kleinkram.wrappers import list_files
@@ -49,6 +50,7 @@
     "get_project",
     "get_template",
     "get_template_revisions",
+    "get_trigger",
     "list_files",
     "list_missions",
     "list_projects",

cli/kleinkram/api/routes.py

@@ -281,11 +281,14 @@ def get_triggers(client: AuthenticatedClient, query: Optional[TriggerQuery] = No
     return list(map(lambda p: _parse_action_trigger(TriggerObject(p)), payload))
 
 
+GET_TRIGGER_ENDPOINT = "/triggers/{}"
+
+
 def get_trigger(
     client: AuthenticatedClient,
     trigger_uuid: UUID,
 ) -> ActionTrigger:
-    resp = client.patch(UPDATE_TRIGGER.format(trigger_uuid), json={})
+    resp = client.get(GET_TRIGGER_ENDPOINT.format(trigger_uuid))
     if resp.status_code == 404:
         raise kleinkram.errors.TriggerNotFound(f"Trigger not found: {trigger_uuid}")
     resp.raise_for_status()

cli/kleinkram/wrappers.py

@@ -298,6 +298,18 @@ def list_triggers(
     return list(kleinkram.api.routes.get_triggers(client, query=query))
 
 
+def get_trigger(
+    trigger_uuid: IdLike,
+    *,
+    client: Optional[AuthenticatedClient] = None,
+) -> ActionTrigger:
+    """\
+    get detailed information for a specific trigger by its uuid
+    """
+    client = client or AuthenticatedClient()
+    return kleinkram.api.routes.get_trigger(client, parse_uuid_like(trigger_uuid))
+
+
 @overload
 def upload(
     *,

cli/tests/test_triggers.py

@@ -14,6 +14,7 @@
 from kleinkram.models import WebhookConfig
 from kleinkram.wrappers import create_trigger
 from kleinkram.wrappers import delete_trigger
+from kleinkram.wrappers import get_trigger
 from kleinkram.wrappers import list_triggers
 from kleinkram.wrappers import update_trigger
 
@@ -49,6 +50,11 @@ def test_trigger_crud_file(empty_mission, action_template):
     assert trigger.config.patterns == ("*.bag", "data/*.csv")
     assert trigger.config.event == (FileTriggerEvent.UPLOAD, FileTriggerEvent.DELETE)
 
+    # Verify via get_trigger
+    trigger_detail = get_trigger(trigger_uuid)
+    assert trigger_detail.uuid == trigger_uuid
+    assert trigger_detail.name == trigger_name
+
     # 3. Update
     new_name = f"trig-upd-{token_hex(4)}"
     new_config = FileConfig(patterns=("*.bin",), event=(FileTriggerEvent.UPLOAD,))