Merge pull request #2288 from leggedrobotics/fix/issue-2238-metadata-update-deletion

fix: metadata update mapping & tag deletion (issue #2238)

Author: wp99cp

backend/src/services/queue.service.ts

@@ -343,7 +343,7 @@ export class QueueService implements OnModuleInit {
                 }
             }
         }
-        return {};
+        return { success: true };
     }
 
     async cancelProcessing(

backend/src/services/tag.service.ts

@@ -195,8 +195,7 @@ export class TagService {
                         value = Number.parseInt(value as string);
                     }
 
-                    // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
-                    (exsitingTag as any)[tagType.datatype] = value as number;
+                    exsitingTag.value_number = value as number;
                     break;
                 }
                 throw new UnprocessableEntityException(
@@ -212,8 +211,7 @@ export class TagService {
                     );
                 }
 
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
-                (exsitingTag as any)[tagType.datatype] = value;
+                exsitingTag.value_string = value;
                 break;
             }
 
@@ -223,8 +221,7 @@ export class TagService {
                         value = value === 'true';
                     }
 
-                    // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
-                    (exsitingTag as any)[tagType.datatype] = value as boolean;
+                    exsitingTag.value_boolean = value as boolean;
                     break;
                 }
 
@@ -239,8 +236,17 @@ export class TagService {
                     );
                 }
 
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
-                (exsitingTag as any)[tagType.datatype] = new Date(value);
+                exsitingTag.value_date = new Date(value);
+                break;
+            }
+            case DataType.LOCATION: {
+                if (typeof value !== 'string') {
+                    throw new UnprocessableEntityException(
+                        'Value must be a string',
+                    );
+                }
+
+                exsitingTag.value_location = value;
                 break;
             }
 
@@ -264,7 +270,7 @@ export class TagService {
 
     async deleteTag(uuid: string): Promise<DeleteTagDto> {
         await this.tagRepository.delete({ uuid });
-        return {};
+        return { success: true };
     }
 
     async getAll(skip: number, take: number): Promise<TagTypesDto> {

frontend/src/services/mutations/tag.ts

@@ -2,9 +2,7 @@ import { DataType } from '@kleinkram/shared';
 import axios from 'src/api/axios';
 
 export const removeTag = async (tagUUID: string) => {
-    const response = await axios.delete('/tag/deleteTag', {
-        params: { uuid: tagUUID },
-    });
+    const response = await axios.delete(`/tag/${tagUUID}`);
     // eslint-disable-next-line @typescript-eslint/no-unsafe-return
     return response.data;
 };

packages/api-dto/src/types/delete-mission-response.dto.ts

@@ -1,2 +1,12 @@
-// eslint-disable-next-line @typescript-eslint/no-extraneous-class
-export class DeleteMissionResponseDto {}
+import { ApiProperty } from '@nestjs/swagger';
+import { IsBoolean } from 'class-validator';
+
+export class DeleteMissionResponseDto {
+    @ApiProperty({
+        description: 'Indicates the deletion was successful',
+        example: true,
+        type: Boolean,
+    })
+    @IsBoolean()
+    success!: boolean;
+}

packages/api-dto/src/types/project/delete-project-response.dto.ts

@@ -1,2 +1,12 @@
-// eslint-disable-next-line @typescript-eslint/no-extraneous-class
-export class DeleteProjectResponseDto {}
+import { ApiProperty } from '@nestjs/swagger';
+import { IsBoolean } from 'class-validator';
+
+export class DeleteProjectResponseDto {
+    @ApiProperty({
+        description: 'Indicates the deletion was successful',
+        example: true,
+        type: Boolean,
+    })
+    @IsBoolean()
+    success!: boolean;
+}

packages/api-dto/src/types/tags/delete-tag.dto.ts

@@ -1,2 +1,12 @@
-// eslint-disable-next-line @typescript-eslint/no-extraneous-class
-export class DeleteTagDto {}
+import { ApiProperty } from '@nestjs/swagger';
+import { IsBoolean } from 'class-validator';
+
+export class DeleteTagDto {
+    @ApiProperty({
+        description: 'Indicates the deletion was successful',
+        example: true,
+        type: Boolean,
+    })
+    @IsBoolean()
+    success!: boolean;
+}